485208 - [Extension] Display issue on Mac

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

Attachment: screenshot

See attached screenshot - the Search pane still thinks it's the first in the list.

Comment 1

[Brian King [:kinger]]

I think this is caused by last-visible and first-visible attributes that are being set dynamically.

Comment 2

[Brian King [:kinger]]

Tentative fix checked in, revision 24004. Am going to let it bake a bit before closing this off.

Comment 3

[Justin Scott [:fligtar]]

This fix works for me, however there is still a slight vertical line through a number of the tabs, visible in the screenshot here.

Comment 4

[Brian King [:kinger]]

Know anyone who worked on the Mac theme that I could ask about this?

Comment 5

[Justin Scott [:fligtar]]

Alex, do you have any ideas on what's causing this issue, or know of a theme-savvy developer we could ask?

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

cc'ing some people

Comment 7

[Markus Stange [:mstange]]

The vertical line should be fixed by bug 479156 - in what build are you seeing it?

Comment 8

[Brian King [:kinger]]

(In reply to comment #7)
> The vertical line should be fixed by bug 479156 - in what build are you seeing
> it?

Firefox 3.0.x and 3.1b3. Seems like it was fixed after. I will try on a more recent build.

Comment 9

[Brian King [:kinger]]

Attachment: No lines in Shiretoko

I've just tested in a Shiretoko (3.5b4) nightly, and the visual nuance is gone. Screenshot attached.

Comment 10

[Brian King [:kinger]]

(In reply to comment #9)
> I've just tested in a Shiretoko (3.5b4) nightly, and the visual nuance is gone.
> Screenshot attached.

Therefore, that wraps up this bug I think. FIXED.

Comment 11

[Justin Scott [:fligtar]]

I think most of our users will be on Firefox 3, at least for a few months after Bandwagon's launch. I don't suppose there's a workaround or a way for the extension to fix this in Firefox 3?

Comment 12

[Markus Stange [:mstange]]

From looking at the code I don't understand how this bug can affect Firefox 3 - are you sure it's visible there? The first/last-visible attributes weren't used there. Instead, the border radius was set on the containing ".radiogroupWrapper".

Comment 13

[Justin Scott [:fligtar]]

Oops, you're right. This isn't a problem in Fx 3. For some reason I thought I had taken the screenshot in 3.

So this should all be good for launch.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with the latest add-on Justin sent me, using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b5pre) Gecko/20090515 Shiretoko/3.5b5pre