485891 - Bottom Border under Column Day Labels is missing.

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[dave.r.wilson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090223 Lightning/1.0pre Thunderbird/3.0b2

Bottom Border under Colum Day Labels is missing in Month and Multiweek Views.

Reproducible: Always




Making the following changes to chrome would fix this problem:

#view-deck .labeldaybox-container
{
  border-bottom: 1px solid #D2D2D2;
}

Comment 1

[Stefan Sitter [:ssitter]]

Could you add a screenshot that shows the issue and a screenshot that shows how it looks with the patch applied?

Comment 2

[dave.r.wilson]

Attachment: Bottom Border under Colum Day Labels is missing (before patch)

Comment 3

[dave.r.wilson]

Attachment: Bottom Border under Colum Day Labels displayed (after patch)

Comment 4

[Bas van den Bosch]

confirmed. Looks better, does Christian still do the UI-reviews?

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I think this doesn't require an explicit ui-r since its probably rather a regression. Could someone check how things look on the mac and create a patch that fixes the issue?

Comment 6

[Decathlon]

This bug is a regression from bug 447683. I posted a comment there the seventh of January.
With patch 351864 http://hg.mozilla.org/comm-central/rev/fe713242a103 were deleted some classes and inside calendar-views.css file there are still css rules related to them (that, IMO, should be deleted, but this is another issue).
E.g. classes:
'calendar-month-view-column-header-container' (http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.9);
'month-view-column-header' (the deleted border of this bug);
'calendar-month-view-column-header-label';
are still in calendar-views.css but don't have anymore corresponding names in xml/xul files.

Comment 7

[Decathlon]

> 'month-view-column-header' (the deleted border of this bug);

...'calendar-month-view-column-header' (the deleted border of this bug);

Sorry!

Comment 8

[Decathlon]

Attachment: patch

As suggested by dave.r.wilson, this patch adds a bottom border to the class 'labeldaybox-container'.
I can't verify how it looks on a mac.

I have to say that you get the same result adding a bottom border to 'calendar-day-label' (top and left borders of every column header are defined with this class. The border on extreme right, instead, is defined with 'labeldaybox-container' class):

 calendar-day-label {
     color: #000000;
     background-color: white;
     background-image: url("chrome://calendar/skin/calendar-day-label-back.png");
     border-left: 1px solid #D2D2D2;
     border-top: 1px solid #D2D2D2;
+    border-bottom: 1px solid #D2D2D2;
 }

don't know what's better.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 376092 [details] [diff] [review]
patch

Daniel, can you take a look if this works as expected on a mac?

Comment 10

[Daniel Boelzle [:dbo]]

Comment on attachment 376092 [details] [diff] [review]
patch

sorry for delay..

looks good; r=dbo

Comment 11

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/9ee52aa76e76>

-> FIXED

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".