485904 - A contradiction in nsImapMailFolder::NormalEndMsgWriteStream

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[palo misik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8 (.NET CLR 3.5.30729) XPCOMViewer/1.0a1
Build Identifier: 

A variable commit is initialized to false and never modified. Boolean statement in if is always false. Is it mistake?

NS_IMETHODIMP
nsImapMailFolder::NormalEndMsgWriteStream(nsMsgKey uidOfMessage,
                                          PRBool markRead,
                                          nsIImapUrl *imapUrl)
{
  PRBool commit = PR_FALSE;
  if (m_offlineHeader)
    EndNewOfflineMessage();
  m_curMsgUid = uidOfMessage;
  if (commit && mDatabase)
    mDatabase->Commit(nsMsgDBCommitType::kLargeCommit);
  return NS_OK;
}


Reproducible: Always

Comment 1

[David :Bienvenu]

It's just unneeded code at this point - I guess at some point long ago we decided that committing after every message store was unneeded...

Comment 2

[palo misik]

then clear an implementation on trunk. 
Everyone who will read this code will asked question I asked.

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to comment #2)
> then clear an implementation on trunk. 
> Everyone who will read this code will asked question I asked.

Palo Feel free to contribute a patch.

Comment 4

[palo misik]

Attachment: Cleared an implementation of nsImapMailFolder::NormalEndMsgWriteStream

Cleared an implementation.

It is my first patch.
Be careful to apply it to trunk.

Comment 5

[David :Bienvenu]

Comment on attachment 370006 [details] [diff] [review]
Cleared an implementation of nsImapMailFolder::NormalEndMsgWriteStream

thx for the patch, looks good.

Instead of "cleared an implementation", saying "remove unused code" would be the more usual way of describing this (I realize English isn't your first language...). Thx again for the patch.

Comment 6

[palo misik]

>I realize English isn't your first language...
You are right. English isn't my first language.

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/ad9dcc1c2d49