Closed
Bug 486345
Opened 15 years ago
Closed 15 years ago
remove testevents sample plugin
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file)
|
39.04 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
We should remove the testevents sample plugin. It is an xpcom plugin and probably not useful to anyone. We don't want to promote the writing of xpcom plugins.
Attachment #370445 -
Flags: superreview?(jst)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 370445 [details] [diff] [review] fix v1.0 - In modules/plugin/sdk/samples/Makefile.in: +ifeq ($(OS_ARCH),WINNT) DIRS = common - -ifeq ($(OS_ARCH),WINNT) It's not clear to me why this change is here. r+sr=jst assuming we really want that change.
Attachment #370445 -
Flags: superreview?(jst)
Attachment #370445 -
Flags: superreview+
Attachment #370445 -
Flags: review+
There's no point to building the common base code for anything that isn't actually going to build a sample plugin right?
pushed to mozilla-central without the makefile change for now http://hg.mozilla.org/mozilla-central/rev/7348ed185ae2
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•