486641 - When replaying a video the audio does not play

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P2)

Description

[cajbir (:cajbir)]

Playing the video in the URL plays both video and audio. When the video completes playing, clicking 'play' again results in the video re-starting but no sound.

Steps to reproduce:

1) Visit URL
2) Click 'Play' button on video controls
3) wait for video to complete
4) Click 'Play' again
5) Notice the absence of sound

What Should Happen:

Sound should be heard on the second playback

What does happen:

No Sound.

The issue appeared when the media cache patch landed I think. It changed 'play' in the case of a completed video so it would seek to the beginning and continue playing. Unfortunately on the completion of the first play the audio stream is 'drained' and the audio handle is no longer usable.

Comment 1

[cajbir (:cajbir)]

Attachment: fix

blocking1.9.1?

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 370815 [details] [diff] [review]
fix

Cool.

It'd be nice if we could assert that the stream isn't reused after Drain() is called, but it seems like it'd need a flag added to nsAudioStream and a bunch of checks all over the place, so it might not be worth the effort.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/918da7a13cc2

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/910536440b48

Comment 5

[Tony Chung [:tchung]]

sound galore.

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre)
Gecko/20090413 Shiretoko/3.5b4pre