Closed
Bug 486681
Opened 15 years ago
Closed 14 years ago
Updates for HPPA/Linux
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: armin76, Assigned: glandium)
Details
Attachments
(1 file, 1 obsolete file)
511 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
Hi, please apply the following patch, it's from debian. What it does is: -Support generic hppa CHOST. -Compile xpcom with -O0, since more than that segfaults. Props to Mike Hommey <glandium at debian dot org> since he did it. Patch should apply to 1.9 as well.
Attachment #370860 -
Flags: review?(timeless)
Attachment #370860 -
Flags: review?(benjamin)
Updated•15 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 1•15 years ago
|
||
Comment on attachment 370860 [details] [diff] [review] hppa.patch Please wait a bit. I'll try to ping some hppa-aware people that promised a real patch a while ago (the ifneq part still applies, though). I tackled what is happening, but lacked the hppa assembly knowledge to come up with a proper fix. The problem lies in the fact that the stubs get a data structure from the stack, but function tail call optimization in the caller function breaks the stack location expectations, which is why building with -O0 works.
Attachment #370860 -
Flags: review?(timeless)
Attachment #370860 -
Flags: review?(benjamin)
Comment on attachment 370860 [details] [diff] [review] hppa.patch i'll gladly give this an r-. clobbering optimizations for a large number of unrelated patches is entirely unacceptable collateral damage.
Attachment #370860 -
Flags: review-
Assignee | ||
Comment 4•15 years ago
|
||
Huh? It's ifdef'ed and wouldn't be -O0 unless compiled on hppa! Anyways, let's wait for the real patch.
ok, so, i'd like this as a patch queue (or export series, whatever). if you're adding an optimization restriction in one patch with an explanation that something is wrong, citing a bug, and in a second patch adding an additional variant of hppa, with an explanation of what it is, then those are two separate patches that should land as distinct changesets.
Reporter | ||
Comment 6•15 years ago
|
||
From xpcom/reflect/xptcall/src/md/unix/Makefile.in:
> 212 ifeq ($(OS_ARCH),HP-UX)
> 213 ifneq ($(CC),gcc)
> 214 ifneq ($(OS_TEST),ia64)
> 215 CPPSRCS := xptcinvoke_pa32.cpp xptcstubs_pa32.cpp
> 216 ASFILES := xptcstubs_asm_pa32.s xptcinvoke_asm_pa32.s
> 217 else
> 218 CPPSRCS := xptcinvoke_ipf32.cpp xptcstubs_ipf32.cpp
> 219 ASFILES := xptcstubs_asm_ipf32.s xptcinvoke_asm_ipf32.s
> 220 endif
> 221
> 222 # #18875 Building the CPP's (CXX) optimized causes a crash
> 223 CXXFLAGS := $(filter-out $(MOZ_OPTIMIZE_FLAGS), $(CXXFLAGS))
> 224 endif
> 225 endif
Adding the part from 221-223 makes it work on HPPA/Linux. So, if its being done for HP-UX, we could do it on Linux, couldn't we?
What do you say Mike?
Reporter | ||
Comment 7•15 years ago
|
||
Mike? :)
Assignee | ||
Comment 8•15 years ago
|
||
(In reply to comment #6) > Adding the part from 221-223 makes it work on HPPA/Linux. So, if its being done > for HP-UX, we could do it on Linux, couldn't we? > > What do you say Mike? I'd say this would be a fix for bug 434190, though modifying the assembly would be better, but I never got the patch from our hppa guys :( That would leave only the generic hppa chost in the patch here. What do you think ?
Reporter | ||
Comment 9•15 years ago
|
||
Dunno, whatever you think its better.
Assignee | ||
Comment 10•14 years ago
|
||
Let's do the chost only, here, and leave the rest to bug 434190
Attachment #370860 -
Attachment is obsolete: true
Attachment #435822 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #435822 -
Flags: review? → review?(timeless)
Attachment #435822 -
Flags: review?(timeless) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 11•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/771a0f0a295b
Assignee | ||
Updated•14 years ago
|
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•