486779 - jsscan: move anonymous function pointer to typdef to silence sunpro cc

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: patch to move anonymous func ptr to typedef

SunPro CC compiler will complain about the anonymous mapfun function pointer because the function declaration is inside of an extern "C" block. Simply moving it out to a typedef shuts up the compiler:

"jsscan.cpp", line 147: Warning: function void(void(*)(const char*)) overloads extern "C" void(extern "C" void(*)(const char*)) because of different language linkages.

Patch creates a JSMapKeywordsFun typedef to silence the warning.

Comment 1

[Andrew Paprocki]

Attachment: patch to move anonymous func ptr to typedef

removed accidental extra newline in the previous patch

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 370988 [details] [diff] [review]
patch to move anonymous func ptr to typedef

>+typedef void (*JSMapKeywordsFun)(const char *);

Nit: function maps one keyword at a time, so the name should use Keyword, singular.

I think we should get rid of this old friend API, but for this bug, with the above fix, r=me.

/be

Comment 3

[Andrew Paprocki]

Attachment: patch to move anonymous func ptr to typedef

updated patch for review nit

Comment 4

[Andreas Gal :gal]

This should go into tracemonkey, not directly m-c

Comment 5

[Dão Gottwald [:dao]]

Could you guys please take care of your TM landings? They tend to get dusty in the checkin-needed queue.

Comment 6

[Phil Ringnalda (:philor)]

Land it or wontfix it: it's grotesque that the tracemonkey checkin-needed queue is eight months long.

Comment 7

[Igor Bukanov]

https://hg.mozilla.org/tracemonkey/rev/987d2e3f7ca3

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/987d2e3f7ca3