487362 - 404 page should only list accessible articles

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[krupa raj[:krupa]]

Steps to reproduce:
1.go to http://support-stage.mozilla.org/en-US/kb/Clearing+Private+Datab
2.Notice the list under Perhaps you were looking for: category

observed behavior:
The first few links have "*" before them whereas the rest are simply listed.(see screenshot

Comment 1

[krupa raj[:krupa]]

Attachment: listing

Comment 2

[Chris Ilias [:cilias]]

Renaming to "404 page should only list accessible articles".

"*Clearing Location bar history" and "Clearing Location bar history" are two separate articles. The asterisk is part of the article name, which indicates that is the staging copy.
See <http://support.mozilla.com/kb/Approving+articles+and+edits>.

One thing that is alarming about that page is that staging copies are listed even when not logged in. It should list articles that accessible to the viewer. So to a person not logged in, it should not list articles in the staging area, sandbox, or archive categories. Similar to what we do with the language selector.

Comment 3

[Paul Craciunoiu [:paulc]]

I think it would be good to also try and list staging + live articles on the same line wherever possible.
E.g. list "Clearing Location bar history" as
"Clearing Location bar history (approved) (staging)" or something of the sort. I suppose that could be a separate bug.

Comment 4

[Paul Craciunoiu [:paulc]]

r24284 / r24285
For some reason, the wikilib function checked the permission on the current page over and over, instead of the suggested pages.

This seems to be a bug in TikiWiki. Sylvie, what do you think?

Comment 5

[sgreverend]

Thanks - committed in tw

Comment 6

[krupa raj[:krupa]]

I still see staging article listed in the 404 page.Check-

http://support-stage.mozilla.org/en-US/kb/How+To+Make+Firefox+The+Default+Browsern


screenshot: http://screencast.com/t/hNVE3usq

So reopening...

Comment 7

[Paul Craciunoiu [:paulc]]

Krupa: it appears that those staging articles are accessible wihout being logged in. As such, they're listed.

Do we want to remove staging articles from this list even if they are accessible to anonymous users?

Comment 8

[Paul Craciunoiu [:paulc]]

Laura, David, Chris, please see comment 7.

Comment 9

[Chris Ilias [:cilias]]

It looks as though those articles are staging copies, but not in the staging area category.

Comment 10

[Paul Craciunoiu [:paulc]]

Chris, this sounds like it can be done manually. Or shall we consider a bug for moving all staging copies to the staging area?

I'm not sure if we implemented that articles shouldn't start with a "*", but they shouldn't.

Comment 11

[Chris Ilias [:cilias]]

They should be in the staging area in the first place, so I'd like to investigate that before moving them.

Comment 12

[Chris Ilias [:cilias]]

Filed bug 489210

Comment 13

[Paul Craciunoiu [:paulc]]

Looks like this doesn't happen anymore. Probably a result of bug 489874 being fixed. Chris, can you confirm?

Comment 14

[Chris Ilias [:cilias]]

confirmed
I also tried http://support-stage.mozilla.org/en-US/kb/Cannot+log+in+to+websitess but could not find a link to an article in the staging area.

We obviously can't check every possible 404 page though.

Comment 15

[Paul Craciunoiu [:paulc]]

Yay! If this occurs again, please reopen :)

Comment 16

[krupa raj[:krupa]]

Paul,
I need a little clarification-
IF I navigate to the 404 page(http://support-stage.mozilla.org/en-US/kb/How+To+Make+Firefox+The+Default+Browsern)..I noticed that the below specified link is listed twice.The second link in this page has no content.


*Firefox не может соединиться по безопасному протоколу, потому что сайт использует старую � (http://tinyurl.com/lzwm7q)

is this the expected behavior? reopening for clarification...

Comment 17

[Paul Craciunoiu [:paulc]]

Ugh. That article title seems pretty buggy. Additionally, the two URLs are different (notice below). I would guess it is not the same article. But there also seem to be some encoding issues here, not a part of this bug. Both of those are articles that are not in the staging area though (if you look at the breadcrumb). They are articles that should be assigned a category, though. I hope that clarifies it.

http://support-stage.mozilla.org/en-US/kb/%2AFirefox+%D0%BD%D0%B5+%D0%BC%D0%BE%D0%B6%D0%B5%D1%82+%D1%81%D0%BE%D0%B5%D0%B4%D0%B8%D0%BD%D0%B8%D1%82%D1%8C%D1%81%D1%8F+%D0%BF%D0%BE+%D0%B1%D0%B5%D0%B7%D0%BE%D0%BF%D0%B0%D1%81%D0%BD%D0%BE%D0%BC%D1%83+%D0%BF%D1%80%D0%BE%D1%82%D0%BE%D0%BA%D0%BE%D0%BB%D1%83%2C+%D0%BF%D0%BE%D1%82%D0%BE%D0%BC%D1%83+%D1%87%D1%82%D0%BE+%D1%81%D0%B0%D0%B9%D1%82+%D0%B8%D1%81%D0%BF%D0%BE%D0%BB%D1%8C%D0%B7%D1%83%D0%B5%D1%82+%D1%81%D1%82%D0%B0%D1%80%D1%83%D1%8E+%D0
http://support-stage.mozilla.org/en-US/kb/%2AFirefox+%D0%BD%D0%B5+%D0%BC%D0%BE%D0%B6%D0%B5%D1%82+%D1%81%D0%BE%D0%B5%D0%B4%D0%B8%D0%BD%D0%B8%D1%82%D1%8C%D1%81%D1%8F+%D0%BF%D0%BE+%D0%B1%D0%B5%D0%B7%D0%BE%D0%BF%D0%B0%D1%81%D0%BD%D0%BE%D0%BC%D1%83+%D0%BF%D1%80%D0%BE%D1%82%D0%BE%D0%BA%D0%BE%D0%BB%D1%83%2C+%D0%BF%D0%BE%D1%82%D0%BE%D0%BC%D1%83+%D1%87%D1%82%D0%BE+%D1%81%D0%B0%D0%B9%D1%82+%D0%B8%D1%81%D0%BF%D0%BE%D0%BB%D1%8C%D0%B7%D1%83%D0%B5%D1%82+%D1%81%D1%82%D0%B0%D1%80%D1%83%D1%8E+%EF

Comment 18

[krupa raj[:krupa]]

looks fixed.

Comment 19

[Paul Craciunoiu [:paulc]]

Let's claim it happened in 1.3 to keep track of it :)

Comment 20

[Louis-Philippe Huberdeau]

Change already made in tiki.