Closed Bug 487595 Opened 15 years ago Closed 15 years ago

TraceMonkey: Don't use the ARM MOVW/MOVT instructions to write to the PC.

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jbramley, Assigned: jbramley)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

Don't use MOV(W|T) to write to PC. Uses "config.thumb2" rather than "config.v6t2".
462 bytes, patch
vlad
: review+
Details | Diff | Splinter Review 
Using MOVW/MOVT to write to the PC will not work as it will be written in two stages.

The attached patch fixes this so that the PC is never written in this way.

This bug has priority "minor" because LD32_nochk is never used to load into the PC (yet).
Attachment #371833 - Flags: review?(vladimir)
Attached patch Use the new config item name. (obsolete) — — Splinter Review 
Actually, that patch won't apply on top of my patch for better processor detection. The new patch should apply on top of the patch for bug 487416.
Attachment #371833 - Attachment is obsolete: true
Attachment #371834 - Flags: review?(vladimir)
Attachment #371833 - Flags: review?(vladimir)
Depends on: 487416
Previous patch didn't apply cleanly, so here is a replacement.
Attachment #371834 - Attachment is obsolete: true
Attachment #371836 - Flags: review?(vladimir)
Attachment #371834 - Flags: review?(vladimir)
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/532a8d5d4685
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: