487866 - Caught exception: undefined when using "Group by: Day" in conjunction with "Active Daily Users" dropdown option

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load https://preview.addons.mozilla.org/en-US/statistics/addon/8585
2. Choose "Active Daily Users" from the dropdown
3. Choose the "Group by: Day" option

Caught exception: undefined

Details: [Exception... "An invalid or illegal string was specified"  code: "12" nsresult: "0x8053000c (NS_ERROR_DOM_SYNTAX_ERR)"  location: "https://preview.addons.mozilla.org/js/simile/amo-bundle.js Line: 8237"]

Screencast: http://screencast.com/t/iWBv5Y5x3f

Comment 1

[Fred Wenzel [:wenzel]]

I think this is fixed in the meantime.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; see the newly attached image.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of "undefined" error

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Not sure if http://www.screencast.com/users/stephendonner/folders/Jing/media/f5f877a9-94a6-4686-8779-75b332f94d93 helps.

Comment 5

[Wil Clouser [:clouserw]]

working for me

Comment 6

[Wil Clouser [:clouserw]]

If this is still a bug please give us steps to reproduce.  I tried in an FF nightly.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Same STR for me always, as in comment 0:

http://screencast.com/t/GP9cc6n2

Comment 8

[Scott McCammon [:mccammos]]

Attachment: Check for divide by zero fix

I wasn't able to consistently reproduce the error in dev so this may be hard to test. The exception seems to be the result of a divide by zero when there is only 1 data point in the csv.

The patch comes directly from the latest timeplot source. We really need to update our modified copy, but that isn't trivial and is best saved for a new bug in itself.

Comment 9

[Wil Clouser [:clouserw]]

Comment on attachment 396614 [details] [diff] [review]
Check for divide by zero fix

please commit

Comment 10

[Scott McCammon [:mccammos]]

Fixed in r50136

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with my original testcase; thanks guys, for taking this.