487981 - TM: remove amd64 code (will be replaced with tamarin's new amd64 backend)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Comment 1

[Andreas Gal :gal]

Attachment: patch

This also fixes a bug in the code generator. We used to emit LEA for constant offset additions, which doesn't update flags, which we do rely on for LIR_ov/LIR_cs. Only use LEA for addp, the address calculation form of addition.

Comment 2

[Andreas Gal :gal]

Seriously, we deleted danderson's account--again?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 372258 [details] [diff] [review]
patch

Nice catch.

Comment 4

[Andreas Gal :gal]

Please read before granting blocking:

This patch contains a 1-line bug fix. That part should block IMO.

As for the rest, it gets us closer aligned with tamarin-redux, which removed the 386 backend.

I would like to apply the entire patch as is. It should not affect 386 builds. The current 64-bit x86 backend is broken, so it will not really affect x86-64 builds either.

If you want me to split out the bugfix from the code removal patch, I can easily do that.

Comment 5

[Andreas Gal :gal]

Ed, do you concur with the LEA change? (and making those if cascades switches)

Comment 6

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/2ee4d920011f

Comment 7

[Edwin Smith]

yes, sounds right to only use LEA for addp, since we don't track condition code liveness.  when we have time to breathe a bit, we should track cc's better in the backend; lea would be fine for an add if the cc's are not expected.

Comment 8

[Andreas Gal :gal]

Yeah, PPC would benefit from more explicit cc tracking. Sparc probably too, to a lesser degree.

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/2ee4d920011f

Comment 10

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4fd30c64c5ed