Closed
Bug 488027
Opened 15 years ago
Closed 15 years ago
summarize_time.cgi compares strings using numeric lt (<)
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: LpSolit, Assigned: wicked)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.15 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
summarize_time.cgi: Argument "2008-01-28" isn't numeric in numeric lt (<) at data/template/template/en/default/bug/summarize-time.html.tmpl line 499. The line is: [% IF bugs.$id.deadline && global.deadline < bugs.$id.deadline %] This is a regression due to bug 286452. Should be fixed before 3.4rc1.
Updated•15 years ago
|
Flags: blocking3.4+
Assignee | ||
Updated•15 years ago
|
Assignee: general → wicked
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•15 years ago
|
||
You should try foo.deadline.replace("-", "") < bar.deadline.replace("-", ""). This should fix your problem as Perl is supposed to convert them to integers implicitly.
Assignee | ||
Comment 2•15 years ago
|
||
It worked perfectly. Additionally this patch protects from comparing with blank global deadline field that happens before a first non-blank bug deadline field is found.
Attachment #373566 -
Flags: review?(LpSolit)
Reporter | ||
Comment 3•15 years ago
|
||
Comment on attachment 373566 [details] [diff] [review] Fix numeric compare, V1 r=LpSolit
Attachment #373566 -
Flags: review?(LpSolit) → review+
Reporter | ||
Updated•15 years ago
|
Flags: approval3.4+
Flags: approval+
Assignee | ||
Comment 4•15 years ago
|
||
Tip: Checking in template/en/default/bug/summarize-time.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v <-- summarize-time.html.tmpl new revision: 1.15; previous revision: 1.14 done 3.4 branch: Checking in template/en/default/bug/summarize-time.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v <-- summarize-time.html.tmpl new revision: 1.14.2.1; previous revision: 1.14 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•