488189 - Allow pork-barrel.py to be reused in other scripts

Status: RESOLVED DUPLICATE of bug 488400

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This entails renaming it and breaking its dependency on global variables (for cleanliness only).

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: importable pork_barrel

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: same patch as before, but filename in command is specified as "%(file)s" instead of "%s"

Sorry, needed to add this feature for a quick test.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: diff of patches v1 and v2

Comment 4

[David Mandelin [:dmandelin]]

Comment on attachment 372492 [details] [diff] [review]
diff of patches v1 and v2

Diffs of diffs are bad for sanity. Either request review on the new patch or just post a patch with the new diffs, please.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 372490 [details] [diff] [review]
same patch as before, but filename in command is specified as "%(file)s" instead of "%s"

Alright.  I figured that the two changed lines would not be very obvious.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Make pork_barrel.py also try to die when the user requests

Last time I add anything to this patch, I promise :).

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This bug was superseded by 488400.