488209 - Article links in e-mail notifications should use bl=n

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Underpass]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.0.8) Gecko/2009032608 Firefox/3.0.8
Build Identifier: 

When you receive an email notifications for article changes, under the text

"You can view the page by following this link:"

the proposed link doesn't have the bl=n notation, so very often is not the link to the intended page but it falls back to your locale.

Reproducible: Always

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch v1

Seems like a simple change, but I don't want to break anything, so we should test this carefully.

Comment 2

[Paul Craciunoiu [:paulc]]

Just a quick note: I'm assigning bugs that are patch-ready to the next milestone, so we can land them sooner rather than later, but of course we can push them out.

Comment 3

[Laura Thomson :laura]

Comment on attachment 384197 [details] [diff] [review]
patch v1

QA++ on this one too.

Comment 4

[Paul Craciunoiu [:paulc]]

r29675 / r29676

Yeah, agree with Laura. Need to test various notifications (not just for articles) to see if links are broken

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; this didn't break my forum-reply notification links, and it *did* put the bl=n parameter suffix correctly on the page changed/created notifications.