488416 - overflow:hidden does not clip windowless plugins on GTK2/X

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

In the testcase, the plugin should be clipped to the red box, but it is not. This is expected for windowed plugins, since we do not give overflow:hidden content a widget, but for windowless I expected it to already work.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: correct testcase

That testcase was wrong.

Comment 2

[Karl Tomlinson (:karlt)]

nptest_gtk2.cpp is ignoring NPWindow::clipRect.
That would be OK if it paid attention to the dirty rect in the expose event.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

It's just a bug in the test plugin.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/8a2f7b9cc481