Closed
Bug 488480
Opened 15 years ago
Closed 9 years ago
Wrong comment about the function hasMatchingOverride() in nsICertOverrideService.idl
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: om.brahmana, Assigned: Cykesiopka)
References
()
Details
Attachments
(1 file, 1 obsolete file)
3.11 KB,
patch
|
Cykesiopka
:
review+
|
Details | Diff | Splinter Review |
The function hasMatchingOverride() in nsICertOverrideService.idl has a wrong comment/description. http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/public/nsICertOverrideService.idl#91 It is an exact replica of the comment for the previous function: http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/public/nsICertOverrideService.idl#72
Comment 1•15 years ago
|
||
There's a patch in bug 466011 that fixes this. It got lost in the mists of time waiting for review, but should still apply pretty cleanly, since the IDL doesn't change much.
Assignee | ||
Comment 3•9 years ago
|
||
This patch contains the relevant bits from johnath's patch in Bug 466011, with very trivial changes.
Attachment #8586562 -
Flags: review?(dkeeler)
Comment on attachment 8586562 [details] [diff] [review] bug488480_correct-hasMatchingOverride()-doc_by-Johnathan-Nightingale_v1.patch Review of attachment 8586562 [details] [diff] [review]: ----------------------------------------------------------------- LGTM with nits addressed. ::: security/manager/ssl/public/nsICertOverrideService.idl @@ +63,3 @@ > * > * @param aHostName The host (punycode) this mapping belongs to > * @param aPort The port this mapping belongs to, if it is -1 then it nit: let's remove trailing whitespace while we're here @@ +63,5 @@ > * > * @param aHostName The host (punycode) this mapping belongs to > * @param aPort The port this mapping belongs to, if it is -1 then it > * is internaly treated as 443 > * @param aCert The cert that should always be accepted I would update this description too. Maybe "The certificate this mapping belongs to". @@ +72,2 @@ > */ > boolean hasMatchingOverride(in ACString aHostName, nit: trailing whitespace
Attachment #8586562 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 5•9 years ago
|
||
+ Address feedback from Comment 4 + Fix typos
Assignee: nobody → cykesiopka.bmo
Attachment #8586562 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8587370 -
Flags: review+
Assignee | ||
Comment 6•9 years ago
|
||
Thanks for the review. https://treeherder.mozilla.org/#/jobs?repo=try&revision=79e43b4ab4c4
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/755da69810a1
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/755da69810a1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•