488782 - Website: Sometimes there are missing preview images/broken links due to rsync doing pages before images

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Sometimes during a push of GetPersonas.com, there are broken links and missing preview images (see screenshot), because rsync seems to take care of pages before images.

(Saw this on http://www.getpersonas.com/gallery/Music/Recent, but this might fix itself by the time this is read.)

Toby can add more more-specific info.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing missing images

Comment 2

[Toby Elliott [:telliott]]

Jeremy - can we futz with the rsynch so that it does the images (the 1-9 directories) before the galleries? The delay difference can actually be quite substantial.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Does the rsync also delete stale files?  If so, doing the images first will cause images to get deleted before updating the pages that refer to them, which is the same problem in reverse.  I guess you could always sync images without deleting any first, then sync pages, then do a sync that deletes stale images.

Comment 4

[Jeremy Orem [:oremj]]

I've changed the rsync 
from:
rsync -aq --delete sm-personas01::personas/ /data/static/www/www.getpersonas.com/static/

to:
rsync -aq --delay-updates --delete-delay sm-personas01::personas/ /data/static/www/www.getpersonas.com/static/

These changes should make it much more atomic.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks like this is still happening on http://www.getpersonas.com/en-US/gallery/All/All/1.