488911 - StretchDIBits takes too long - switch between optimizations at run time

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

+++ This bug was initially created as a clone of Bug #484864 +++

We will have more than one code path for painting on windows, right now the code path is chosen at build time with preprocessor macros. It would be better to choose the path at run time based on prefs.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: use pref to determine this at runtime

This depends on bug 488910

This patch adds a mozilla.widget.render-mode pref, that takes an int that corresponds to the new WinRenderMode enum.  It's only read in at start time, though we could add a pref observer to toggle it at runtime as well.

Most of this is just an indentation change, sadly; I can see if I can coax a diff -w patch out of hg if that would be easier to review.

Comment 2

[Jim Mathies [:jimm]]

Hmm, can you post a updated patch? This didn't apply cleanly to m-c.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It won't, not without the patches in bug 488910.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 373749 [details] [diff] [review]
use pref to determine this at runtime

Alright, just eye balling it everything looked ok.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/7fc81369ff6a