488962 - OS/2 build broken with GCC 4.4.0-rc

Status: RESOLVED DUPLICATE of bug 487567

(NSS :: Libraries, defect)

Description

[Paul Smedley]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090418 Minefield/3.6a1pre
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090418 Minefield/3.6a1pre

OS/2 build breaks with GCC 4.4.0-rc - patch below resolves break:
diff --git a/security/nss/lib/freebl/os2_rand.c b/security/nss/lib/freebl/os2_rand.c
--- a/security/nss/lib/freebl/os2_rand.c
+++ b/security/nss/lib/freebl/os2_rand.c
@@ -364,10 +364,10 @@ static void rng_systemJitter(void)
    dwFileToRead++;
    if (dwFileToRead >= dwNumFiles) {
	dwFileToRead = 0;
    }
}

size_t RNG_SystemRNG(void *dest, size_t maxLen)
{
-    return rng_systemFromNoise(dest,maxlen);
+    return rng_systemFromNoise(dest,maxLen);
}

this has clearly always been a bug, just previous GCC versions allowed it

Reproducible: Always

Steps to Reproduce:
1. Build using GCC 4.4.0
2.
3.
Actual Results:  
Build breaks

Expected Results:  
Build works :)

Comment 1

[Walter Meinl]

Paul, the fix is already in NSS HEAD, but we have to wait until this gets into mozilla-central and mozilla-1.9.1 (you'll need the change posted above also for SM, TB and FF-3.5pre beta)

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

NSS 3.12.3 has been released.  

Regarding NSS, Mozilla's various Hg repositories are "down stream" from 
the CVS source.  The NSS team does not update down stream repositories.
It's up to the maintainers of each down stream repository to update their 
repositories with new releases of NSS as they choose.  

Someone has already updated the Hg repository from which FF 3.5 is built 
to use NSS 3.12.3, IINM.  I have no idea who would do that for the Hg 
repository from which Thunderbird is built.