488984 - when draging tab to content area aEvent.screenX/Y in _onDragEnd is always 0 (breaks tab tearing)

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090417 Firefox/3.5.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090417 Firefox/3.5.0

After fixed Bug 466379 -  Need mouse-pointer coordinates in the dragend event ,
when draging tab to content area aEvent.screenX/Y in _onDragEnd is always 0

See https://bugzilla.mozilla.org/show_bug.cgi?id=475066#c69


Reproducible: Always

Actual Results:  
0 is always returned. 

Expected Results:  
The right coordinates are returned.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This will stop tearing off tabs into content area. See referenced comment in comment 0. Asking for blocking FF3.5.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Mano: can you please look into this, if you need Windows testing, co-ordinate with someone on IRC, preferably Enn.

Enn: can you please determine why _onDragEnd is returning 0 in this case?

Comment 3

[Neil Deakin]

Attachment: handle this when a drop occurs as well

Haven't tested this on Windows yet.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Jim: can you help Neil out on this?

Comment 5

[Jim Mathies [:jimm]]

Attachment: handle this when a drop occurs as well v2

Just a slight update for win. The drag end event in FireDragEventAtSource had values that were populated correctly.

Comment 6

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/f365e3bc979b

Comment 8

[Justin Dolske [:Dolske]]

Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f9840fdb8b01

Comment 9

[Asaf Romano (gone)]

Where's the sr?

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

I didn't realize this code required an sr. Who is appropriate?

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Alice: has this been fixed in the latest nightly? Can you confirm?

Comment 12

[Asaf Romano (gone)]

roc, probably.

Comment 13

[Alice0775 White]

(In reply to comment #11)
> Alice: has this been fixed in the latest nightly? Can you confirm?
I can confirmed that it was fixed in the Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090421 Shiretoko/3.5b4pre ID:20090421042301.