489306 - overflowed content doesn't expose child text accessibles

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

<div style="overflow: auto">long content</div> doesn't expose child text accessible. I suspect bug 483573 because there we introduced walking through frames if there is anonymous content. I have wip patch that fixes the problem (fix logic of a11y tree walker) and will post it once I'll polish it.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

short description: when I added querying to anonymous content creator then a11y tree walker founds scrollbar element in the case of overflowed div, scrollbar isn't accessible so it checks it first child , GetFirstChild is called again and then GetKids. GetKids sees it's XUL element so it nulls frame of current state before we put the current state on stack.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 373824 [details] [diff] [review]
patch

>+   * DOM/frame subtree duiring searching of accessible children.

Nit: Typo "diuring" instead of "during".

>+   * Pop state from stack and makes it current.

Nit: Either "pops state...and makes..." or "pop state...and make it..." I'd prefer the latter (the one with pop and make).

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 373824 [details] [diff] [review]
patch

r=me

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 373824 [details] [diff] [review]
patch

must be landed with bug 483573

Comment 5

[alexander :surkov (:asurkov)]

checked in http://hg.mozilla.org/mozilla-central/rev/81273d925ba9

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373824 [details] [diff] [review]
patch

a191=beltzner

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch 1.9.1

Comment 8

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090503 Minefield/3.6a1pre (.NET CLR 3.5.30729)

Comment 9

[alexander :surkov (:asurkov)]

checked in on mozilla1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fe1a4c1e4fa0