489581 - Reduce Addref/Release when calling event handlers

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Depending on the case this speeds up event handling up to 6-7%.
Usually a lot less.

I need to run tests...

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Btw, I found this while debugging nsCxPusher::Push/JSContextStack::Push

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 374070 [details] [diff] [review]
patch

Passed the tests.

So I'm swapping out-param and return value.
Even though changes to nsContentUtils::GetContextForEventHandlers are simple, it needs to be reviewed carefully.

NS_ENSURE_SUCCESS in nsXHREventTarget::AddEventListener isn't actually a must-have, but since I added the comment that caller must check the rv value...

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 374070 [details] [diff] [review]
patch

Looks good to me, and I did look through nsContentUtils::GetContextForEventHandlers() in detail as well.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/24bb97995e9b