489944 - @title attribute no longer exposed on accDescription

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

This is a regression from 3.0, where the title attribute's value was exposed as accDescription for links and images. I've confirmed it is broken on both mozilla-central and mozilla-1.9.1.

Comment 1

[Marco Zehe (:MarcoZ)]

Works in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081010 Minefield/3.1b2pre (.NET CLR 3.5.30729)

Is broken in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081011 Minefield/3.1b2pre (.NET CLR 3.5.30729)

Regression range:
http://hg.mozilla.org/mozilla-central/shortlog/035cf0234960
Candidate: Bug 453591

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)

> Candidate: Bug 453591

Right (http://hg.mozilla.org/mozilla-central/diff/5eb98035a8a0/accessible/src/base/nsAccessible.cpp)

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 4

[alexander :surkov (:asurkov)]

clarification: previously GetTextFromRelationID returned NS_ERROR_FAILURE if there is no aria-describedby attribute, bug 453591 changed it to NS_OK.

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 374443 [details] [diff] [review]
patch

>+    function doTest()
>+    {
>+      // aria-label

Nit: Please include a test for aria-describedby as well. And change the comment accordingly.

>+  <img id="img1" title="title">
>+  <img id="img2" alt="name" title="description">

Nit: I'd prefer if the tags were closed with /> instead of >.

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 374443 [details] [diff] [review]
patch

r=me with those nits fixed. I confirmed that NVDA indeed again picks up the title for an image or link if asked for it.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #4)
> clarification: previously GetTextFromRelationID returned NS_ERROR_FAILURE if
> there is no aria-describedby attribute, bug 453591 changed it to NS_OK.

Heh, reminds me of bug 381048

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 374443 [details] [diff] [review]
patch

r=me if all a11y suite tests pass. (and with Marco's nits)

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 374443 [details] [diff] [review]
patch

Alexander, this is the part I'm confused about (in our IRC chat)

>   // 4. its title attribute already equals to its accName nsAutoString name; 
>   nsCOMPtr<nsIContent> content(do_QueryInterface(mDOMNode));
>-  if (!content) {
>-    return NS_ERROR_FAILURE;  // Node shut down
>-  }
>+  NS_ASSERTION(content, "No content of valid accessible!");
>+  if (!content)
>+    return NS_OK;
>+

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

If you return an error instead of the NS_OK as per our chat, that works for me.

Comment 11

[alexander :surkov (:asurkov)]

Attachment: patch2

with Marco and David wishes

Need to port on 1.9.1, regression fix

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 374454 [details] [diff] [review]
patch2

looks better thanks.

Comment 13

[Marco Zehe (:MarcoZ)]

Pushed on Alexander's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/0390afd7fc62

Comment 14

[alexander :surkov (:asurkov)]

Thank you, Marco!

Comment 15

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090503 Minefield/3.6a1pre (.NET CLR 3.5.30729)

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 374454 [details] [diff] [review]
patch2

a191=beltzner

Comment 17

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on Alexander's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ddc9a48a1509

Comment 18

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090507 Shiretoko/3.5b5pre (.NET CLR 3.5.30729)