490282 - Trigger choice of customization sheet from a pref instead of a build-time widget ifdef

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

The other half of stealing the benefits from SeaMonkey's deathmarch to customizable toolbars, following on from bug 489047 - by making the choice between using a dialog and the panel pretending to be a sheet we use on OS X based on a pref instead of a build-time MOZ_WIDGET_TOOLKIT = cocoa ifdef, we can not only clean up a bunch of defines, but we can also make it possible for people without a Mac to see at least approximately what they are doing to the sheet-panel without needing to make a ton of changes and rebuild each time.

The cost, an unneeded DTD and a panel containing a hidden iframe that won't ever have a src attribute, seems pretty small.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 374732 [details] [diff] [review]
Fix

r=Standard8.

Bonus points if you work out what happened to our icons on the customise sheet on the main mail window.

Comment 2

[Phil Ringnalda (:philor)]

Huh, you're missing icons? All, or just some? I think I've got a full load myself, though "what happened" would have to be me screwing up stylesheet overlays in bug 489047, or maybe ordering from the smime over-inclusion thing.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/bc4a5c45d3ac