490635 - Download manager: pause button disabled

Status: VERIFIED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[philippe (part-time)]

Attachment: screenshot

What the summary says: the download manager lists 6 downloads, the pause button is disabled.
Removing the plist out of my profile restores the functionality.

I'm not clear how this happened. I'll monitor the situation over the next few days.
Quick checking the plist file in a texteditor and Property List Editor.app  doesn't show anything wrong.

Comment 1

[philippe (part-time)]

Attachment: offending plist file (zipped)

The last download in the list (fx 3.5b4-1) is me testing... I cancelled that download.

Comment 2

[Chris Lawson (gone)]

I saw this yesterday, I think. Not sure what was going on; I didn't think of removing the plist so I may still have the brokenness in my setup. I'll double-check tonight.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I can reproduce this on a fresh profile in 2009-04-22 by doing the following:

1) Download a file
2) Quit
3) Relaunch Camino
4) Start downloading another file

2.0b2 running on that same profile is fine.

We last really touched the dlmgr in bug 483532, which in turn was a regression from bug 406103 (cl had some l10n fixes, but my guess is this wouldn't be them).  My guess is this is another regression from bug 406103, but I don't have the builds handy atm.

We need to fix this for 2.0.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This broke between 3-24 and 3-25, which actually points at bug 483532 :P  (There are other checkins in this range, http://tinyurl.com/cvldk6, but only bug 483532 seems likely.)

Comment 5

[Ilya Sherman]

Attachment: Fix

Thanks to all, esp. Smokey, for helping to track this down :)

Comment 6

[Nick Kreeger]

Comment on attachment 375131 [details] [diff] [review]
Fix

+    return [[self window] isKeyWindow];
+  } else {
+    [theItem setImage:[NSImage imageNamed:@"dl_pause"]];    
+    [theItem setLabel:NSLocalizedString(@"dlPauseButtonLabel", nil)];

NIT: Note that the current Camino style guide defines that the else should be on a new line.

Comment 7

[Ilya Sherman]

Attachment: Fix, nit addressed

Comment 8

[Ilya Sherman]

Attachment: Fix, proper patch

I am *so* bad at hand-editing patch files.  Should actually be possible to apply this patch now.

Comment 9

[Stuart Morgan]

Comment on attachment 375141 [details] [diff] [review]
Fix, proper patch

sr=smorgan

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk; nice work!

Comment 11

[philippe (part-time)]

Verified using the STR in comment 3, with a new profile and with my default profile. I also tested with the plist attached.

Version 2.0b3pre (1.9.0.11pre 2009050114)

Thanks.