491138 - bespin.editor.Component is missing some "includes"

Status: RESOLVED EXPIRED

(Skywriter Graveyard :: Editor, defect)

Description

[René]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_6; de-de) AppleWebKit/528.16 (KHTML, like Gecko) Version/4.0 Safari/528.16
Build Identifier: http://hg.mozilla.org/labs/bespin/file/3200b58128b0

bespin.editor.Component is missing some "dojo includes". If this component is used to embed the editor into a webpage (as it is used in frontend/tests/manual/editor/singleeditor.html) the editor has no syntax highlighting enabled. Setting stuff then sometimes leads to a dojo error related to cookies. As it turns out, there are some includes missing.

Fix for the cookie error:
   dojo.require("dojo.cookie");

Fix for the syntax highlighting:
   dojo.require("bespin.syntax.simple.javascript");
   dojo.require("bespin.syntax.simple.css");
   dojo.require("bespin.syntax.simple.html");
   dojo.require("bespin.syntax.simple.php");

Reproducible: Always

Steps to Reproduce:
1. open frontend/tests/manual/editor/singleeditor.html
Actual Results:  
Embedded editor without syntax highlighting

Expected Results:  
Embedded editor with syntax highlighting

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

You seem to have done more research into this than I have, so I'm going to assume you know what you're talking about and confirm this.

I'm also categorizing this under "Editor".

Comment 2

[Kevin Dangoor]

The embeddable editor component has changed to a single file (embed.js) that 
includes everything necessary. The syntax highlighting engine has also changed 
to dynamically load the highlighters for different languages.

One thing that may be desirable is some way to configure a custom embeddable 
build. That would be a separate and different feature request, I think.

The latest embedded build can be found at https://bespin.mozilla.com/embed.js