491143 - View - Feed Message Body As - Default doesn't work

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

newsblog's utils.js defines const RDF_NS but suite's bookmarks.js (as used by the Bookmark This Link context menu option) already declares it as a var. This means that an exception is thrown when the view as default code tries to dynamically import utils.js and therefore nothing gets shown at all.

Comment 1

[Ian Neal]

As it is only used in one line in utils.js could just do remove:

const RDF_NS = "http://www.w3.org/1999/02/22-rdf-syntax-ns#";
const RDF_TYPE = rdf.GetResource(RDF_NS + "type");

and instead have:

const RDF_TYPE = rdf.GetResource("http://www.w3.org/1999/02/22-rdf-syntax-ns#type");

Comment 2

[[e-mail]]

Yeah, that works, thanks.

Comment 3

[Ian Neal]

Attachment: Fix duplicate declaration v0.1 (Pushed: Comment 4)

This patch:
* Removes duplicate declaration from newsblog's utils.js so it does not break View -> Feed Message Body As -> Default in SeaMonkey.

Comment 4

[Ian Neal]

Comment on attachment 375596 [details] [diff] [review]
Fix duplicate declaration v0.1 (Pushed: Comment 4)

http://hg.mozilla.org/comm-central/rev/2580d4920e20