Closed
Bug 491190
Opened 15 years ago
Closed 12 years ago
fix miscellaneous warnings in networking modules
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 745296
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 2 obsolete files)
15.45 KB,
patch
|
Biesinger
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Attachment #375515 -
Flags: superreview?(cbiesinger)
Attachment #375515 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Attachment #375515 -
Flags: superreview?(cbiesinger) → superreview+
Comment 2•15 years ago
|
||
Comment on attachment 375515 [details] [diff] [review] wrong patch this patch is identical to attachment 375514 [details] [diff] [review], you probably meant to attach a different one to this bug?
Attachment #375515 -
Attachment is obsolete: true
Attachment #375802 -
Flags: superreview?(cbiesinger)
Attachment #375802 -
Flags: review?(cbiesinger)
Attachment #375515 -
Flags: review?(ted.mielczarek)
Attachment #375515 -
Attachment description: patch → wrong patch
Attachment #375515 -
Flags: superreview+
Attachment #384278 -
Flags: superreview?(cbiesinger)
Attachment #384278 -
Flags: review?(cbiesinger)
Attachment #375802 -
Attachment is obsolete: true
Attachment #375802 -
Flags: superreview?(cbiesinger)
Attachment #375802 -
Flags: review?(cbiesinger)
Comment 5•15 years ago
|
||
Comment on attachment 384278 [details] [diff] [review] updated +++ b/modules/libjar/nsJARInputStream.cpp + if ((PRUint32)bytesRead != aCount) { can you use a constructor-style cast instead? (if (PRUint32(bytesRead) ...)) +++ b/modules/libjar/nsZipArchive.cpp + if ((PRUint32)byteCount < (namelen + extralen + commentlen + sizeof(sig))) { here too +++ b/netwerk/build/nsNetModule.cpp +#undef assert why this? +++ b/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp + if (aInLength < 0 || pos >= (PRUint32) aInLength) { constructor-style cast + (nsCRT::IsAsciiAlpha(lastChar = aInString[i]) || + nsCRT::IsAsciiDigit(lastChar))) I think it would be better to just use aInString[i] in both these lines and not change lastChar. + PRInt32 index; why declare that up here? +++ b/netwerk/streamconv/src/nsAppleFileDecoder.cpp - long count = dataCount; + SInt32 count = dataCount; + if (noErr != FSWrite(m_rfRefNum, &count, buffPtr) || + (PRUint32) count != dataCount) Does this meean that the documentation is incorrect? http://developer.apple.com/documentation/mac/devices/Devices-33.html +++ b/netwerk/streamconv/src/nsAppleFileDecoder.h -#define NUM_ENTRIES 6 +#define NUM_ENTRIES 6 if you're removing tabs on other lines, remove them here as well? :)
Attachment #384278 -
Flags: superreview?(cbiesinger)
Attachment #384278 -
Flags: review?(cbiesinger)
Attachment #384278 -
Flags: review-
Comment 6•15 years ago
|
||
oh... ignore the first two comments, looks like libjar doesn't really do that style of casts
Updated•13 years ago
|
Whiteboard: [build_warning]
Updated•13 years ago
|
Blocks: buildwarning
Comment 7•12 years ago
|
||
We're getting rid of necko warnings in bug 745296
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•