Closed
Bug 491196
Opened 15 years ago
Closed 15 years ago
don't implement static functions in headers
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file, 2 obsolete files)
|
8.87 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #375517 -
Flags: superreview?(cbiesinger)
Attachment #375517 -
Flags: review?(sdwilsh)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 375517 [details] [diff] [review] patch I'd prefer if the header declaration was moved to mozStoragePrivateHelpers.h, and the implementation moved to the cpp file. r=sdwilsh with that change. Also, you don't need sr for this module.
Attachment #375517 -
Flags: superreview?(cbiesinger)
Attachment #375517 -
Flags: review?(sdwilsh)
Attachment #375517 -
Flags: review+
|
||
Updated•15 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [needs patch addressing review comment]
Version: unspecified → Trunk
Attachment #375517 -
Attachment is obsolete: true
Attachment #377303 -
Flags: review?(sdwilsh)
Attachment #377303 -
Attachment is obsolete: true
Attachment #377305 -
Flags: review?(sdwilsh)
Attachment #377303 -
Flags: review?(sdwilsh)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 377305 [details] [diff] [review] blah >+++ b/storage/test/unit/test_statement_wrapper_automatically.js >+++ b/storage/test/unit/test_storage_statement_wrapper.js >+ // function JSValStorageStatementBinder in >+ // storage/src/mozStorageStatementParams.cpp tells us that the following types wrong function name now r=sdwilsh
Attachment #377305 -
Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/975b1965bb8c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs patch addressing review comment]
You need to log in
before you can comment on or make changes to this bug.
Description
•