491272 - ##channel links don't always get munged correctly

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

If you stick this through the munger, the 1st and 3rd channels are missing the # in the link:
  ##foo ##foo :) ##foo ##foo

This happens because the start of the channel-link munger is /(?:\s|\W|^) and the \W eats the # before ^ gets a go. The fix I originally came up with was just /(?:^|\s|\W) which is never going to survive if the regexp engine changes.

My new fix is /(?:\s|[^\w#]|^) which also fixes it and isn't as unstable. :)

Comment 1

[:Gijs (he/him)]

(In reply to comment #0)
> If you stick this through the munger, the 1st and 3rd channels are missing the
> # in the link:
>   ##foo ##foo :) ##foo ##foo
> 
> This happens because the start of the channel-link munger is /(?:\s|\W|^) and
> the \W eats the # before ^ gets a go. The fix I originally came up with was
> just /(?:^|\s|\W) which is never going to survive if the regexp engine changes.
> 
> My new fix is /(?:\s|[^\w#]|^) which also fixes it and isn't as unstable. :)

Why is the \s needed? Doesn't [^\w#] already cover whitespace? (same for \W, really)

Comment 2

[James Ross]

If you can show it's unnecessary in testing, feel free to remove it.

Comment 3

[:Gijs (he/him)]

Attachment: Patch

OK, I nuked the \s at least for this one... Seems to work fine. Do you want me to get rid of it for the other regexes, too?

Comment 4

[James Ross]

Sure, remove it from any with the same pattern.

Comment 5

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.22; previous revision: 1.21
done