Closed
Bug 491661
Opened 15 years ago
Closed 29 days ago
Clear Recent History dialog needs unified margins for ui elements
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: whimboo, Unassigned)
References
Details
(Keywords: polish, Whiteboard: [polish-easy] [polish-visual][polish-p3])
Attachments
(1 file)
39.71 KB,
image/jpeg
|
Details |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090504 Shiretoko/3.5b5pre ID:20090504031110 Right now, the margins of the ui elements inside the Clear Recent History dialog looks like they are randomly placed around a given position. We should give unique margins to the border and between the elements. See the attached screenshot on OS X.
Comment 1•15 years ago
|
||
Could you be more specific? Bug 489700 replaces the CSS margin under the dropdown with a separator between the dropdown and the warning. A separator is already under the warning, so margins under and above the warning should be equal once that patch lands. Other than that there's the margin between the progressive disclosure button and item list, but I figured the margin ought to be smaller there since the list and button are really one unit.
Reporter | ||
Comment 2•15 years ago
|
||
Ok, here some examples: * Really obvious is the margin between the buttons and the bottom corner of the window. That's too wide when comparing to all the other elements. * vertical space between elements is different, e.g warning and disclosure control or disclosure control and listbox or listbox and buttons Alex could probably come up with a nice mockup?
Updated•15 years ago
|
Whiteboard: [polish-easy] [polish-visual]
Comment 3•15 years ago
|
||
This bug's priority relative to the set of other polish bugs is: P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p3]
Updated•2 years ago
|
Severity: minor → S4
Comment 4•29 days ago
|
||
Resolved with new clear history dialog UI --> Bug 1853996 - [meta] Revamp Clear Data Dialog
Status: NEW → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•