491739 - change geolocation prompt strings for 3.5 final

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Design should look like:

foo.com wants to know your location (Learn More...)   (Share Location) (Don't Share) [ ] Remember for this site

so that's changing 2 strings:

 geolocation.shareLocation=Share Location
 geolocation.dontTellThem=Don't Share

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

Attachment: screenshot

Comment 3

[Staś Małolepszy :stas]

I'd suggest adding a comment (a localization note) in
browser/locales/en-US/chrome/browser/browser.properties that would say
something to the effect of: "If you're having trouble with the word Share,
please use Allow and Block in your language." The reason for this is that we
don't use the verb "Share" almost anywhere in Firefox, so putting it in here
requires localizers to come up with a translation of a new word, while Allow
and Block are well-established in the l10n land and we use them a lot
(especially in privacy-related strings, e.g. in Page Info > Permissions; also
see bug 491732)

Does this make sense?

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 376103 [details] [diff] [review]
patch v.2

I think .accesskey is preferred over just appending "key".

We should get an accesskey for the remember checkbox, too (R seems to work), but maybe that's best done in a trunk only followup? Not sure.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: with Remember accesskey

I had this applied for testing, figured I'd attach it. We can take this only on trunk if the 1 extra string addition is a problem for branch.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: without Remember accesskey

Comment 8

[Doug Turner (:dougt)]

gavin, lets do the checkbox access key in bug 491769?

Comment 9

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/e4f29e0faf9a
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/78d6f3d51d82

Comment 10

[Doug Turner (:dougt)]

Comment on attachment 376083 [details]
screenshot

removing request. this bug has been fixed.