491774 - crashreporter fails to compile when doing 32-bit cross compile on Mac OS X 10.6 seed 10A335

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Josh Aas]

Attachment: mozconfig for reproducing, v1.0

The crash reporter fails to compile when doing a 32-bit cross-compile on Mac OS X 10.6, where 64-bit is the default arch. Use the attached mozconfig and Mozilla trunk code to reproduce on Mac OS X 10.6 seed 10A335 (or later).

(No, I am not using a PDP-11!)

Comment 1

[(not currently active) Ted Mielczarek]

Also, need this filed upstream, since we don't take local patches. Happy to sync with upstream if we get it fixed there, though.

Comment 2

[Josh Aas]

Attachment: build failure output

Comment 3

[(not currently active) Ted Mielczarek]

Ok, so it looks like we just need another block here that sets CPU_TYPE_X86_64:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/common/mac/macho_walker.cc#63

Can you patch that and submit it upstream?

Comment 4

[Josh Aas]

Attachment: partial fix v1.0

Its not really that easy, breakpad lacks 64-bit support in general for darwin so doing that isn't enough. Here is a patch that does it though because I have a question - what is the right alternative to __i386__ to use for x86-64? __LP64__ will also be true for 64-bit PPC.

Comment 5

[Josh Aas]

Attachment: 64-bit build errors

Comment 6

[Benjamin Smedberg]

defined(__x86_64__)

Comment 7

[(not currently active) Ted Mielczarek]

(In reply to comment #4)
> Created an attachment (id=376468) [details]
> partial fix v1.0
> 
> Its not really that easy, breakpad lacks 64-bit support in general for darwin
> so doing that isn't enough.

Should be ok, though, since we disable breakpad support on 64-bit systems in configure. Only dump_syms (and its bits) need to compile, since we compile those for the host architecture, but they only need to deal with x86 binaries.

Comment 8

[(not currently active) Ted Mielczarek]

I wouldn't block on this. You can always --disable-crashreporter.

Comment 9

[(not currently active) Ted Mielczarek]

Josh, this is fixed now, right?

Comment 10

[Josh Aas]

yes

Comment 11

[[e-mail] (:bhearsum)]

I'm hitting this with the latest mozilla-central, with 10.6 and Xcode 3.2.1, and a universal build setup -- I think this got regressed.

Comment 12

[Jim Blandy :jimb]

Attachment: Breakpad Mac Dumper: Fix compilation warnings on OS X 10.6

Breakpad's Macintosh symbol dumper uses deprecated functions for
dealing with mixed-endianness code. This patch provides an overloaded
function, ByteSwap, that automatically chooses the CFSwap* functions
from <CoreFoundation/CFByteOrder.h> appropriate for its argument's
size.

Comment 13

[Jim Blandy :jimb]

Attachment: Breakpad Mac dumper: Build cleanly as a 64-bit program.

Since we're using its types, #include <stdint.h>.

Don't cast 'void *' to 'uint32_t' where we need to do byte-pointer
arithmetic. Instead, use 'char *'; the language guarantees that
sizeof(char) == 1.

To make the above easier, pass pointers to byte buffers as 'char *', not
'void *.

Use natural pointer arithmetic where possible. If ptr is a 'struct A *', then
write:
        (struct B *) (ptr + 1)
instead of:
        (struct B *) ((char *) ptr + sizeof(struct A))
This helps us avoid (say) using the size of the 32-bit Mach-O header to
skip a 64-bit Mach-O header. (The latter has an extra 32-bit word at the
end.)

Comment 14

[Jim Blandy :jimb]

With those two patches, I can get dump_syms to build for x86_64.  I don't think it runs, though.

Comment 15

[Jim Blandy :jimb]

Those patches filed with Google as:
http://breakpad.appspot.com/71001/show
http://breakpad.appspot.com/70001/show

Comment 16

[Jim Blandy :jimb]

The patch series up at the URL below fixes the symbol dumper on Mac.  It works fine compiled as either 32-bit or 64-bit code.

Comment 17

[Jim Blandy :jimb]

The URL:
http://hg.mozilla.org/users/jblandy_mozilla.com/breakpad-mq/file/8e6f6dd0b0d6

We'll be importing this into the tree as soon as it gets reviewed upstream.

Comment 18

[Jim Blandy :jimb]

Verified that all unit tests build and pass on Mac x86_64.

Comment 19

[(not currently active) Ted Mielczarek]

Fixed by the update in bug 567424.