Closed
Bug 491835
Opened 15 years ago
Closed 15 years ago
Add entry for allow/disable/remember geolocation to Permissions tab in Page Info
Categories
(SeaMonkey :: Page Info, defect)
SeaMonkey
Page Info
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b2
People
(Reporter: kairo, Assigned: philip.chee)
References
Details
Attachments
(1 file)
5.09 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
We should add allow/disable/remember geolocation to the Permissions tab in Page Info, just as Firefox did in bug 491732. The conversion from content pref to permissions service in there sounds like a good idea as well.
Assignee | ||
Comment 1•15 years ago
|
||
Taking bug. > The conversion from content pref to > permissions service in there sounds like a good idea as well. Appears to have been fixed in some other bug. > We should add allow/disable/remember geolocation to the Permissions tab in Page > Info, just as Firefox did in bug 491732. I tested this against google maps. The Google geolocation service found the right country but the wrong state and placed me right in the middle of a major highway, but I guess that's a google bug not ours.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #388020 -
Flags: superreview?(neil)
Attachment #388020 -
Flags: review?(neil)
Reporter | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > > The conversion from content pref to > > permissions service in there sounds like a good idea as well. > > Appears to have been fixed in some other bug. Yes, we pulled, that into the the other one. > > We should add allow/disable/remember geolocation to the Permissions tab in Page > > Info, just as Firefox did in bug 491732. > > I tested this against google maps. The Google geolocation service found the > right country but the wrong state and placed me right in the middle of a major > highway, but I guess that's a google bug not ours. Yes, what location you get is completely up to Google.
Comment 3•15 years ago
|
||
Comment on attachment 388020 [details] [diff] [review] Patch v1.0 straight port [Checkin: Comment 7] Firefox are getting good at this ;-)
Attachment #388020 -
Flags: superreview?(neil)
Attachment #388020 -
Flags: superreview+
Attachment #388020 -
Flags: review?(neil)
Attachment #388020 -
Flags: review+
Assignee | ||
Comment 4•15 years ago
|
||
> Firefox are getting good at this ;-)
Well I did fix the broken ARIA/focus stuff that I fixed in the rest of our Permissions tab, and that is still broken in Firefox ;-)
Comment 5•15 years ago
|
||
(In reply to comment #4) > > Firefox are getting good at this ;-) > Well I did fix the broken ARIA/focus stuff that I fixed in the rest of our > Permissions tab, and that is still broken in Firefox ;-) Have you filed a bug?
Assignee | ||
Comment 6•15 years ago
|
||
In reply to comment #5) > Have you filed a bug? Filed Bug 504053
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•15 years ago
|
Attachment #388020 -
Attachment description: Patch v1.0 straight port. → [for checkin] Patch v1.0 straight port.
Comment 7•15 years ago
|
||
Comment on attachment 388020 [details] [diff] [review] Patch v1.0 straight port [Checkin: Comment 7] http://hg.mozilla.org/comm-central/rev/16d40cae21eb
Attachment #388020 -
Attachment description: [for checkin] Patch v1.0 straight port. → Patch v1.0 straight port
[Checkin: Comment 7]
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•