491957 - [mozmill] - Main Menu of Options (Preferences)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: AakashDesai_Options_testRestoreHomeToDefault.js

The following test Open the options dialog and verifies each pane opens and displays the correct pane associated with the button.

This test case won't work on Windows until the Bug listed in the "Depends On"
section is fixed.

It references litmus testcases:

 *  Testcase ID #5970 - Main Menu of Options (Preferences)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 376325 [details]
AakashDesai_Options_testRestoreHomeToDefault.js

>var setupModule = function(module) {
>  controller = mozmill.getBrowserController();
>  prefController = mozmill.getPreferencesController();

No need for controller here. Remove it. Further add the module prefix too.

> *  Testcase ID #5970 - Main Menu of Options (Preferences)
> */
>var testOptionsPanes = function(){
>    
>  // Click on the Main Pane and verify its the correct pane and OS after UI catches up
>  prefController.click(new elementslib.Lookup(prefController.window.document, '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"paneMain"}'));
>  prefController.sleep(150);
>  prefController.assertNode(new elementslib.ID(prefController.window.document, "browserHomePage"));

You don't have to check for the correct pane. Just click on all the selectors. Further you can do that in a loop. See attachment 376482 [details] [diff] [review] as an example. You can use the pane member for the identification. Also use a global delay.

>  // Close the Preferences Dialog Box

nit: it's a window

>  prefController.keypress(new elementslib.Lookup(prefController.window.document, '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})'),27,false,false,false,false);
>}

Can you fire this event against the window itself please?

Comment 2

[Aakash Desai [:aakashd]]

Attachment: AakashDesai_Options_testOptionsPanes.js

Crap, cancel that last attachment, Henrik. That was the wrong testscript.

Here's the real one. Sorry about that!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 376799 [details] [diff] [review]
AakashDesai_Options_testOptionsPanes.js

>  // Click on the Main Pane and verify its the correct pane and OS after UI catches up
>  prefController.click(new elementslib.Lookup(prefController.window.document, '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"paneMain"}'));
>  prefController.sleep(150);
>  prefController.assertNode(new elementslib.ID(prefController.window.document, "browserHomePage"));

Please don't use sleep here. Take a look at the utilsAPI and use its delayedAssertNode function for all your checks in this test. I get a lot of failed tests because of the delayed loading of the preference panes.

Further build an array of the panes so you can cycle through:
http://hg.mozilla.org/qa/mozmill-tests/rev/8460e0729f29

As an example for this test something like the following would be great;

var panes = [{pane: 'paneMain', id: 'browserStartupPage'},
             ...
             {pane: 'paneAdvanced', id: 'checkDefaultBox'}
            ];

Then you can operate on panes[ii].pane to click on the button and panes[ii].id to check for the element.

I'll update my page info test to do the same there.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, the page info window test has been updated. Aakash, please use the same way for the preferences window. Don't check elements in the panels but the panel itself. All of them have an id.

see http://hg.mozilla.org/qa/mozmill-tests/rev/232eb68682bb

Comment 5

[Aakash Desai [:aakashd]]

Attachment: testOptionsPanes.js

Test case has been updated to be more in-line with the PageInfo test case. Also, the testscript name has been updated as well to work with the annotations of the codebase.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 377483 [details]
testOptionsPanes.js

>const paneTemplate = '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/';

Move this down into the test please.

>const gDelay = 150;

Still wanna have a delay of 0 here.

>  var panes = [
>               {button: '{"pane":"paneMain"}', panel: 'paneMain'},
>               {button: '{"pane":"paneTabs","label":"Tabs"}', panel: 'paneTabs'},
>               {button: '{"pane":"paneContent","label":"Content"}', panel: 'paneContent'},
>               {button: '{"pane":"paneApplications","label":"Applications"}', panel: 'paneApplications'},
>               {button: '{"pane":"panePrivacy","label":"Privacy"}', panel: 'panePrivacy'},
>               {button: '{"pane":"paneSecurity","label":"Security"}', panel: 'paneSecurity'},
>               {button: '{"pane":"paneAdvanced","label":"Advanced"}', panel: 'paneAdvanced'}
>              ];

Please remove all the additional label attributes. They are not needed and will break the test for other locales.

>  for each (pane in panes) {
>	  var prefPane = paneTemplate + pane.button
>	  
>	  prefController.click(new elementslib.Lookup(prefController.window.document, prefPane));
> 	  prefController.sleep(gDelay);
>	  
>	  // Check if the panel has been shown
>      var node = new elementslib.ID(prefController.window.document, pane.panel);
>      utils.delayedAssertNode(prefController, node);

Please use 2 space indentation overall.

Otherwise it looks good.

Comment 7

[Aakash Desai [:aakashd]]

Attachment: testOptionsPanes.js

Here's the new version after that last set of comment #6

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 377503 [details]
testOptionsPanes.js

Aakash, please set the correct mime type and requestee the next time. Thanks.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 377503 [details]
testOptionsPanes.js

I made some improvements to your test and will upload it in a second.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: updated test

Aakash, accordingly to the litmus test we should at least check if the buttons have an image and label assigned. The label you can get with getAttribute() called on the node itself. The image is assigned via CSS and you can get it by querying the list-style-image CSS attribute.

Comment 11

[Aakash Desai [:aakashd]]

Dunno if this is really possible as the CSS files choose a certain OS  (files shown below) and iwdths and heights to cut off the png image.

http://mxr.mozilla.org/mozilla1.9.1/source/browser/themes/winstripe/browser/preferences/preferences.css

http://mxr.mozilla.org/mozilla1.9.1/source/browser/themes/pinstripe/browser/preferences/preferences.css

http://mxr.mozilla.org/mozilla1.9.1/source/browser/themes/gnomestripe/browser/preferences/preferences.css

If you know how to do that, please tell me as I have no idea!

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Meanwhile I'm not sure anymore if we should compare the button images. Mikeal what do you think? Mozmill isn't designed for image comparisons. Shall we leave those things out?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The preferences dialog API has been implemented. See bug 486407 for an example how to implement it.

Aakash, please leave the image alone. It doesn't look like something we can easily check with Mozmill. Tracy, are the images in the tabstrip of the preference dialog covered by Eggplant?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Working patch after API implementation

This patch contains all the changes which are needed to run tests against the preferences dialog. Please use the same way in all the other tests.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Checked in as: http://hg.mozilla.org/qa/mozmill-tests/rev/b0eaf9e85a67

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.