Closed Bug 492072 Opened 15 years ago Closed 15 years ago

libsydneyaudio compile problem on Mac OS X (particularly 10.6)

Categories

(Core :: Audio/Video, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
"libsydneyaudio" uses things like "ComponentDescription" but doesn't include all the necessary headers (CoreServices). Looks like we get away with it on <= 10.5 but not on 10.6.

I assume we pull this code in from somewhere, we should upstream any fix.
Attachment #376438 - Flags: review?(chris.double)
Blocks: 468509
Comment on attachment 376438 [details] [diff] [review]
fix v1.0

Thanks, I'll organise upstreaming it. In the meantime can you add a note to README_MOZILLA referencing this bug, and include the patch file in the directory so I don't overwrite it in the next libsydneyaudio update if it hasn't been upstreamed by then. You'll see similar patches there that haven't been upstreamed yet.
Attachment #376438 - Flags: review?(chris.double) → review+
Attached patch fix v1.1Splinter Review
Adds the patch to the tree, document in README.
Attachment #376438 - Attachment is obsolete: true
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/998d6f6e95b7
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: