49325 - JavaAdapter method lookup does not follow prototype chain

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect, P3)

Description

[Matthias Radestock]

Define a simple Java interface as follows:

public interface Foo {
    public int bar(int x);
}

and then run the following Javascript program:

var foo = {}
foo.__proto__.bar = function(x) { return x; }
foo.bar(10);	//=> 10
var f = new JavaAdapter(Packages.Foo,foo);
f.bar(10);	//=> 0

The invocation of "bar" on "f" returns 0 instead of 10. That is because 
JavaAdapters do not follow the prototype chain on attribute/method lookup.

btw, we get "0" because of another problem - a failed method lookup results in 
"undefined" being returned, which gets converted to 0 by the JavaAdapter.

Comment 1

[Matthias Radestock]

Attachment: fix for both problems - I haven't done any extensive testing on this, but it *does* fix the test case

Comment 2

[Norris Boyd]

Attachment: Another proposed patch

Comment 3

[Norris Boyd]

I believe my changes to your patch handle the case where the function isn't 
defined more rigorously. (Curse my initial laziness to not fix the TODO.)

What do you think?

Comment 4

[Matthias Radestock]

Norris, your fix looks good to me.

Comment 5

[Norris Boyd]

Cool. Thanks for all your help with these. You're fast with the patches!

I'll run regression tests on this change tonight and check it in tomorrow if all 
goes well.

Comment 6

[Norris Boyd]

Sorry--a little slow on this.

Checking in now.