493485 - "Offline Website data" is wrapped to a second line in Settings for Clear History dialog

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Offline Website Data needs two lines

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090517 Minefield/3.6a1pre ID:20090517031025

With the patch on bug 480898 the entry for "Offline Website data" is wrapped into a second line. See the attached screenshot.

Comment 1

[(no longer active)]

This is actually a regression from bug 490655 which made the dialog too narrow without considering the other use of that entity in the Settings for Clear Recent History dialog.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

Adding [non-l10n-impact string change] here like bug 490655.  Axel, please advise if you don't agree.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ehsan, when do you plan to check-in this patch?

Comment 5

[(no longer active)]

I thought the tree rules stated that only patches can land on m-c which are meant to land on 1.9.1 as well...  Am I mistaken?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No, you are right. Sorry for that.

Comment 7

[Drew Willcoxon :adw]

Ehsan, this has become confusing, but 29em is still too narrow on OS X.  In the 1.9.1 patch at bug 490655 -- which has landed -- I took the 29em number from your patch here.  But if you open up a recent nightly on OS X, the label still wraps as mentioned in this bug.  I should have verified that 29em was OK.

So this is the current state:
- trunk: 28em
- 1.9.1: 29em

And they're both too narrow. :\

I just verified that 31em is the narrowest that works on all three platforms.  (Incidentally that's only 1em smaller than what it originally was before I started with bug 490655...)

Comment 8

[(no longer active)]

Thanks for the evaluation, Drew.  I think given that this is not likely to land on 1.9.1 at this stage, let's WONTFIX this in favor of bug 494210.