493614 - Update homepage promo admin module to use DB for taglines and names

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Nick Nguyen [:osunick]]

For 5.0.6, we had to use static files for the home page promo module, but this needs to move into the DB so we can update featured collections on-demand.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: SQL you gotta run

Renaming a misnamed key that conflicts with my new table and creating the new table.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: v1

This pretty much just copies the scaffolding from Platforms.  This would probably be automatic if we weren't using cake! ;)

Also worth mentioning, creating new features gives a whole bunch of SQL errors but it still works.  The other ones (platforms, categories, etc.) do the same thing so I think fixing it is low priority and out of scope for this bug.

If this gets r+'d the only thing left in this bug is a script to load the current strings from the .po into the database.

Comment 3

[Fred Wenzel [:wenzel]]

Comment on attachment 384812 [details] [diff] [review]
SQL you gotta run

you want to add this to schematic.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 384813 [details] [diff] [review]
v1

Seems to work well!

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> (From update of attachment 384812 [details] [diff] [review])
> you want to add this to schematic.

Can't add it until you commit and get a revision number, right?

Comment 6

[Fred Wenzel [:wenzel]]

Hm yea, I was thinking the same thing earlier. Don't know if I like the whole revision number thing for our DB migrations. I had to make one up for bug 497276, because otherwise it would not be applied for users who already ran the schematic script before.

Comment 7

[Wil Clouser [:clouserw]]

r28392 for what we have so far

Comment 8

[Wil Clouser [:clouserw]]

Attachment: import l10n

Import the L10n from the .po's.  I've got a script that generates this now.  w00t.

Comment 9

[Wil Clouser [:clouserw]]

Attachment: use the promobox stuff

> If this gets r+'d the only thing left in this bug is a script to load 
> the current strings from the .po into the database.

Yeah, that's pretty much a lie.  I forgot that we actually have to use this in the code, not just CRUD the tables.

Comment 10

[Fred Wenzel [:wenzel]]

Comment on attachment 385124 [details] [diff] [review]
import l10n

At least line 175 is broken, it has invalid quotes.

Comment 11

[Wil Clouser [:clouserw]]

Attachment: fix my lame sauce

aww, old copy of the file.

Comment 12

[Fred Wenzel [:wenzel]]

Comment on attachment 385125 [details] [diff] [review]
use the promobox stuff

I didn't see any problems with it, works for me.

Comment 13

[Fred Wenzel [:wenzel]]

Comment on attachment 385150 [details] [diff] [review]
fix my lame sauce

Yup, this data works.

Comment 14

[Wil Clouser [:clouserw]]

in r28519 & SQL run on preview.  Migration script in r28521.