494035 - loading ogg file causes browser to grow memory footprint to several gig

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Christopher Blizzard (:blizzard)]

Tried on the 1.9.1 branch as well as trunk.  Loading the above file and playing it in Firefox will cause it to grow to a couple of gig on my mac and it never plays the file.

It was apparently generated using ffmpeg 0.5.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Yeah, it was generated by ffmpeg 0.5

Steps:

1- http://blip.tv/file/2137910 Downloaded divx version
2- Converted with ffmpeg 0.5 macports edition with just: ffmpeg -i input file output.ogg

I have generated the file with ffmpeg2theora on Mac and it plays nice.

Comment 2

[Christopher Blizzard (:blizzard)]

Greg Maxell says it plays fine in oggplayer and player_example.  It plays fine in VLC on the mac as well.

Comment 3

[Christopher Blizzard (:blizzard)]

Greg just found that the file is encoded with flac as the audio stream.  We should handle that gracefully because ffmpeg is going to generate this crap from time to time.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think we should block on this at this stage, but it sounds like a fix would be pretty easy, maybe we can get it in.

Comment 5

[cajbir (:cajbir)]

Attachment: Fix

The flac track was being marked as active even though we don't support flac. This triggers a liboggplay bug where active tracks that don't have backend support (we disable it in build flags in supporting libraries) cause this memory growth issue.

Fixed by only activating the tracks we are actually know we want to play.

Also fixed a bug where after seek we activated all tracks in the file rather than the audio and video track we are playing.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 379042 [details] [diff] [review]
Fix

Low risk. Stops us from blowing up when we encounter videos containing tracks we can't handle (which do exist).

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 379042 [details] [diff] [review]
Fix

a191=beltzner

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/1b43b06c2052

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bfc06fd863ae

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on trunk and 1.9.1 with builds on Windows and OS X like:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031214