Closed
Bug 494051
Opened 15 years ago
Closed 15 years ago
Make us not fall off trace when accessing "window".
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
652 bytes,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
Spin-off from bug 492649. Right now we'll fall off trace if script accesses the global property window, which is of course pretty common. Fixing it is trivial, see attached patch.
Attachment #378705 -
Flags: superreview?(mrbkap)
Attachment #378705 -
Flags: review?(mrbkap)
|
||
Updated•15 years ago
|
Attachment #378705 -
Flags: superreview?(mrbkap)
Attachment #378705 -
Flags: superreview+
Attachment #378705 -
Flags: review?(mrbkap)
Attachment #378705 -
Flags: review+
Attachment #378705 -
Flags: approval1.9.1+
|
Assignee | |
Comment 1•15 years ago
|
||
Fixed on trunk and branch. http://hg.mozilla.org/mozilla-central/rev/39ecde227c8d http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b380d9251b9b
|
|
Assignee | |
Comment 2•15 years ago
|
||
Backed out of 1.9.1 to see if this caused bug 494255. http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ca05a66098b7
Keywords: fixed1.9.1
|
||
Updated•15 years ago
|
Assignee: nobody → jst
|
||
Comment 3•15 years ago
|
||
Backing out doesn't seem to have changed txul.
|
|
Assignee | |
Comment 4•15 years ago
|
||
Yes. But given the fact that this buys us very little, if anything, I'm not going to check this back into 1.9.1. Once we're able to stay on trace through a XOW, we'll benefit from this, but until then, not really.
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 378705 [details] [diff] [review] Fix. Unmarking approval per jst.
Attachment #378705 -
Flags: approval1.9.1+
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•