494505 - Promo module on home page is too tall and no link to collection in promo module

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Nick Nguyen [:osunick]]

including radius, it should be about 105 px tall:
http://people.mozilla.org/~jscott/bandwagon/clearleft/v11/Home-Shopping.png

preview has it at 180 px tall.

Lots of extra white space and the module pushes too much content below the fold at 180px.  Truncate descriptions at 80 characters to make space.

Other thing missing- there should be a link to the collection using the collection's real name (not the placeholder set in the admin tool)

English text should be "View the <link><collection name> Collection</link>"

Comment 1

[Wil Clouser [:clouserw]]

This is all part of 491581.  I don't know why this would block 494519 so I'm removing that.

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: v1

First stab, asking Les to review as he wrote the first version of the collection promo controller code.

This also has a fix for bug 495356

Comment 3

[Ryan Doherty (:rdoherty)]

(In reply to comment #2)
> This also has a fix for bug 495356

Reason for this is the code change was so tiny I just did it with this patch. Normally wouldn't.

Comment 4

[Les Orchard [:lorchard]]

Comment on attachment 380550 [details] [diff] [review]
v1

This works for me - but I think bigger changes for the collections promo box might be in store.

See: https://bugzilla.mozilla.org/show_bug.cgi?id=494862#c5

Not sure what to do about that, yet.

Comment 5

[Ryan Doherty (:rdoherty)]

r26778

For QA:
The height is as close as possible, it is still off by a few pixels.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

I think we're happy with this on https://addons.mozilla.org/en-US/firefox/.

Verified FIXED.