494800 - [regression] Local directory browsing - 'file:' string overlap filename on RTL

Status: NEW

(Core :: Networking, defect, P5)

Description

[Tomer Cohen :tomer]

Attachment: ar screenshot

Bug 348233 which have been landed recently to 1.9.1 and 1.9.2 fixed an issue of the local directory browser not being RTL for ar/fa/he locales. 

It seems now that the issue have a small regression, of which the 'file:' string is overlapping the file name. This issue appears only for files, and the folder icon appears at the right side of the file name as expected. 

Tested the following browsers, all on my Ubuntu Linux 9.04 box - 

Mozilla/5.0 (X11; U; Linux i686 (x86_64); ar; rv:1.9.1pre) Gecko/20090525 Shiretoko/3.5pre
Mozilla/5.0 (X11; U; Linux i686 (x86_64); fa; rv:1.9.1pre) Gecko/20090525 Shiretoko/3.5pre
Mozilla/5.0 (X11; U; Linux i686 (x86_64); he; rv:1.9.1pre) Gecko/20090525 Shiretoko/3.5pre


Under Windows build (that's a lie, I've used Wine) I am able to see this as expected. Seems that the icon for 'regular file' is missing on Linux, which may make this bug to be a theme issue. 

Mozilla/5.0 (Windows; U; Windows NT 5.1; he; rv:1.9.1pre) Gecko/20090525 Shiretoko/3.5pre

Comment 1

[Tomer Cohen :tomer]

The image moz-icon://.exe?size=16 is not showing for me on Linux but on Windows(wine), and the overlapping text is just the alternative text. As far as I know, the icon is a resource file and not part of the theme, but I don't sure if it has direct connection with Core::Networking. 

Please move this bug to more appropriate location if you think it is required.

Comment 2

[(no longer active)]

Did this work correctly before bug 348233?  IOW, is it really a regression from that bug?  What happens in non-RTL builds?

What happens when you type moz-icon://.exe?size=16 in your location bar?  Are you seeing this problem with all file types?

Comment 3

[Tomer Cohen :tomer]

As I said, I am not sure if the image is missing because of the checkin (probably not), but the alternative text should be displayed in a readable manner even on RTL builds.

Comment 4

[(no longer active)]

I tried this on Ubuntu 9.04, and I couldn't reproduce.

There are two problems here:
1. moz-icon://.ext should produce a valid image.  You probably need to file a new bug in Core::ImageLib about the fact that moz-icon is broken on your system.
2. We should decide whether having |alt| on these images is even useful or not.  The only reason I can think of is accessibility, but we already include the file name next to the image.
3. We should determine whether the fact that alt text runs into the file name is RTL specific or not.  For this, you need to provide screenshots from your machine running an LTR locale.

Comment 5

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258