494880 - Uninitialised value at nsImapIncomingServer::PromptForPassword()

Status: RESOLVED WORKSFORME

(MailNews Core :: Networking: IMAP, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Valgrind says:

==8114== Conditional jump or move depends on uninitialised value(s)
==8114==    at 0x57722C2: nsImapIncomingServer::PromptForPassword(nsACString_internal&, nsIMsgWindow*) (nsImapIncomingServer.c
==8114==    by 0x41D288E: NS_InvokeByIndex_P (in /usr/lib/thunderbird-3.0b3pre/libxpcom_core.so)
==8114==    by 0x41C9B98: nsProxyObjectCallInfo::Run() (nsProxyEvent.cpp:181)
==8114==    by 0x41C439F: nsThread::ProcessNextEvent(int, int*) (nsThread.cpp:510)
==8114==    by 0x418EFD7: NS_ProcessNextEvent_P(nsIThread*, int) (nsThreadUtils.cpp:227)
==8114==    by 0x5E13340: nsBaseAppShell::Run() (nsBaseAppShell.cpp:170)
==8114==    by 0x5EB5101: nsAppStartup::Run() (nsAppStartup.cpp:193)
==8114==    by 0x4144A7B: XRE_main (nsAppRunner.cpp:3298)
==8114==    by 0x804943D: main (nsMailApp.cpp:103)

from nsImapIncomingServer.cpp file:
----------------------------------------------------
nsImapIncomingServer::PromptForPassword()
{
  ...   
  ...

  NS_ENSURE_SUCCESS(rv,rv);
  rv =  GetPasswordWithUI(passwordText, passwordTitle, aMsgWindow,
                          &okayValue, aPassword);
  return (okayValue) ? rv : NS_MSG_PASSWORD_PROMPT_CANCELLED;
}
-----------------------------------------------------

It's because outcoming argument okayValue of nsMsgIncomingServer::GetPasswordWithUI() is not set. I think it could have some default value (TRUE?) even if the password prompt dialog is not shown.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: simple fix

Comment 2

[David :Bienvenu]

Comment on attachment 379678 [details] [diff] [review]
simple fix

Thx for looking into this. It's a bit more complicated than this, unfortunately. IDL methods aren't supposed to set out params in error conditions, and callers aren't supposed to trust out params in error cases, so I think this should be fixed in nsImapIncomingServer::PromptForPassword by initializing okayValue there (and I think PR_TRUE is OK, though the code is a bit complicated).

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Passing to Jan...

Comment 4

[:aceman]

Is anybody from Redhat working on this?
Or should I refresh the patch?

Comment 5

[Mark Banner (:standard8)]

The function no longer exists, and has been reworked:

http://hg.mozilla.org/comm-central/annotate/ed69c6a773d6/mailnews/imap/src/nsImapIncomingServer.cpp#l2184

Hence, I think we can call this WFM.