Closed
Bug 495420
Opened 15 years ago
Closed 15 years ago
Refactor test cases to check enough runs
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bradh, Unassigned)
References
Details
Attachments
(1 file)
|
5.35 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.10) Gecko/2009042708 Fedora/3.0.10-1.fc9 Firefox/3.0.10
Build Identifier:
We have a lot of code in the input_end() functions that looks like:
if (r.testsRun != 1) {
print("Error: must be 1 tests run, instead ran " + r.testsRun);
} else {
r.list();
}
It would be nice to factor that out.
Reproducible: Always
|
Reporter | |
Comment 1•15 years ago
|
||
Also throws in a few newlines on the end of files that missed them.
Attachment #380403 -
Flags: review?(tglek)
|
||
Updated•15 years ago
|
Attachment #380403 -
Flags: review?(tglek) → review?(dmandelin)
|
||
Updated•15 years ago
|
Attachment #380403 -
Flags: review?(dmandelin) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 380403 [details] [diff] [review] refactoring of duplicated code Good idea.
|
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/54fabccc5a49
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•