Closed
Bug 49561
Opened 24 years ago
Closed 24 years ago
Typo creates extremely deep CSS selector
Categories
(SeaMonkey :: UI Design, defect, P1)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jrgmorrison, Assigned: bugs)
References
()
Details
(Keywords: perf, Whiteboard: [nsbeta3+])
Decided to make it a bug report so we don't forget this one. A comma was left out, making two three-deep child selectors into a six-deep descendant selector. That would take a few cycles. treeitem[type="http://home.netscape.com/NC-rdf#Folder"][open="true"] > treerow > .treecell-bookmark treeitem[type="http://home.netscape.com/NC-rdf#IEFavoriteFolder"][open="true"] > treerow > .treecell-bookmark { list-style-image: url("chrome://communicator/skin/bookmarks/bookmark-folder-open.gif"); }
Reporter | ||
Comment 1•24 years ago
|
||
Nominating nsbeta3. Descendant CSS selectors are known to have big performance penalties, particularly in <tree> widgets.
Reporter | ||
Comment 2•24 years ago
|
||
Might as well note that at ~line 103 in the same file, there are adjacent child selectors (i.e., 'foo > > bar'). I have no idea what that would try to match, but it can't be right. treeitem[type="http://home.netscape.com/NC-rdf#Folder"][id="NC:PersonalToolb arFolder"][open="true"] > > treerow > .treecell-bookmark { list-style-image: url("chrome://communicator/skin/bookmarks/personal-folder- open.gif"); } treeitem[selected="true"][type="http://home.netscape.com/NC-rdf#Folder"][id= "NC:PersonalToolbarFolder"][open="true"] > > treerow > .treecell-bookmark { list-style-image: url("chrome://communicator/skin/bookmarks/personal-folder- open-sel.gif"); } p.s., I realize that we now have three skins in the tree; the above can be found in both the modern and blue (the skin formerly known as modern).
Updated•24 years ago
|
Priority: P3 → P1
Whiteboard: [nsbeta3+]
Comment 3•24 years ago
|
||
Nav triage team: nsbeta3+, P1
Assignee | ||
Comment 4•24 years ago
|
||
fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•24 years ago
|
||
(Okay, this may be annoying, but ...) Your checkin didn't include the two instances where there are 'foo > > bar' selectors, which may also equate to really deep descendant selectors.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•24 years ago
|
||
got it this time.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•