Closed
Bug 495833
Opened 15 years ago
Closed 15 years ago
Kinetic scrolling causes panning after user has stopped movement
Categories
(Firefox for Android Graveyard :: Panning/Zooming, defect)
Tracking
(fennec1.0+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 1.0+ | --- |
People
(Reporter: mfinkle, Assigned: bcombee)
Details
Attachments
(1 file, 3 obsolete files)
1.72 KB,
patch
|
Details | Diff | Splinter Review |
* Load a pannable webpage (http://planet.mozilla.org is long enough) * Begin panning * After moving your finger a short distance, stop - but do not release your finger * With the pan stopped raise your finger Actual result: The page moves a small distance due to kinetic Expected result: The page does not move at all, since I had stopped panning before raising my finger
Reporter | ||
Updated•15 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 1•15 years ago
|
||
I've noticed this too. I suggest that if there isn't significant movement for .3s at the end of the momentum buffer, we abort any kinetic movement. This would detect cases where the user stops moving her finger intentionally. That time could be adjusted during UI tuning.
Assignee | ||
Comment 2•15 years ago
|
||
Reporter | ||
Comment 3•15 years ago
|
||
Comment on attachment 384652 [details] [diff] [review] Add logic to abort kinetic movement when user stops >+ if ((Math.abs(mb[i].sx - sX) + Math.abs(mb[i].sy - sY)) > 10) { the "10" is my only concern. It may be too small for devices where the DPI is high. Did you test this on a device?
Reporter | ||
Comment 4•15 years ago
|
||
perhaps use a: const kMinimumKineticThreshold = 10;
Assignee | ||
Comment 5•15 years ago
|
||
I like the idea of a constant or perhaps a pref. I've not yet tested on a device; I really need to update my n810 build this afternoon. I figured we'd need to tune that, and maybe the .3s threshold too.
Comment 6•15 years ago
|
||
we're using 50 as a threshold in the input handler http://mxr.mozilla.org/mobile-browser/source/chrome/content/InputHandler.js#261
Assignee | ||
Comment 7•15 years ago
|
||
Incorporating feedback from mfinkle and blassey
Attachment #384652 -
Attachment is obsolete: true
Attachment #384738 -
Flags: review?(pavlov)
Attachment #384652 -
Flags: review?(pavlov)
Assignee | ||
Comment 8•15 years ago
|
||
Attachment #384738 -
Attachment is obsolete: true
Attachment #384763 -
Flags: review?(pavlov)
Attachment #384738 -
Flags: review?(pavlov)
Assignee | ||
Updated•15 years ago
|
Flags: wanted-fennec1.0?
Summary: Kinetic scrolling doesn't update it's momentum well enough → Kinetic scrolling causes panning after user has stopped movement
Assignee | ||
Comment 9•15 years ago
|
||
Attachment #384763 -
Attachment is obsolete: true
Attachment #384898 -
Flags: review?(mark.finkle)
Attachment #384763 -
Flags: review?(pavlov)
Updated•15 years ago
|
tracking-fennec: ? → 1.0+
Updated•15 years ago
|
Flags: wanted-fennec1.0?
Assignee | ||
Comment 10•15 years ago
|
||
DougT has similar ideas in bug 503362
Assignee | ||
Comment 11•15 years ago
|
||
Applied patch in bug 503362 fixed problem this patch was trying to solve.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•15 years ago
|
Attachment #384898 -
Flags: review?(mark.finkle)
Comment 12•15 years ago
|
||
I'm still seeing a small move after I release my finger (after stopping) on finance.yahoo.com. I'm re-opening to get some traction on this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•15 years ago
|
||
Trying this out on my n810... I see the very minor moves after lifing the finger after a stop, but only when zoomed out. This isn't the same behavior that was originally related to this bug -- that small move isn't from the kinetic module sending additional events. I think this might be from phantom mouse moves sent by Maemo after the mouse up event.
Assignee | ||
Comment 14•15 years ago
|
||
Open a new bug for the left over moves if that's a real issue. I didn't think it was too annoying.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → INVALID
Assignee | ||
Comment 15•15 years ago
|
||
I mean to say the original problem is still fixed.
Resolution: INVALID → FIXED
Comment 16•15 years ago
|
||
If that's the case, then bug 511997 was created for the other issue. This is verified FIXED on builds: Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821 Fennec/1.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre) Gecko/20090808 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Component: General → Panning/Zooming
You need to log in
before you can comment on or make changes to this bug.
Description
•