495969 - Weave JAR file shouldn't be compressed

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Wladimir Palant]

Weave currently uses maximum compression for its JAR file. This has a negative effect on the overall compression of the XPI package (142 kB difference though that's mostly because all the 2.5 MB jQuery are currently included). It also has a negative effect on the application performance, retrieving files from an uncompressed JAR file is faster.

Comment 1

[Wladimir Palant]

Attachment: Proposed patch

Comment 2

[Dan Mills [:thunder]]

The full jQuery was very much a mistake, I backed it out.  But more to the point--if compression is unwanted, why are JARs desired at all?  Why not bypass the JAR altogether and just ship the files as they are in the XPI?

Comment 3

[Wladimir Palant]

I think, reading from a single file tends to be faster than reading from a dozen files (less seek operations on the disk, better use of OS caching).

Comment 4

[Dan Mills [:thunder]]

Comment on attachment 381098 [details] [diff] [review]
Proposed patch

Ok, r=thunder

Comment 5

[Wladimir Palant]

Forgot to mention that using a JAR file makes the installation quite a bit faster :)

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/f8efc7c13729

Comment 7

[Igor Velkov]

... and uses less OS file handles...