Closed Bug 496057 Opened 15 years ago Closed 15 years ago

TM: "Assertion failure: original == thisv || original == OBJECT_TO_JSVAL(obj)" on eBay Motors

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1

People

(Reporter: jruderman, Assigned: gal)

References

(
URL
)

Details

(Keywords: assertion, verified1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
1.79 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
On mozilla-central, loading http://www.motors.ebay.com/ triggers:

Assertion failure: original == thisv || original == OBJECT_TO_JSVAL(obj), at /Users/jruderman/central/js/src/jstracer.cpp:6758
Flags: blocking1.9.1?
Blocking per Andreas.
Flags: blocking1.9.1? → blocking1.9.1+
Assignee: general → gal
Flags: blocking1.9.1+ → blocking1.9.1?
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1
Attached patch patch — — Splinter Review 
Flags: blocking1.9.1? → blocking1.9.1+

    
    

    
  
Check whether a 'with' object is the original 'this' that was handed in, instead of checking after calling the 'this' hook. I really don't like wrappers and the 'this' hook and 'with', and here all are in one bug. Nice.

    
  

        Attachment #381211 -
        Flags: review?(mrbkap)

    
    

    
  
Comment on attachment 381211 [details] [diff] [review]
patch

No wrappers involved here, only with.

        Attachment #381211 -
        Flags: review?(mrbkap) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/2e43c8da18a8
Whiteboard: fixed-in-tracemonkey

    
    

    
  
Yeah, go easy on wrappers :-P.

/be

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/2e43c8da18a8
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
How can that happen?
Flags: in-testsuite?

    
    

    
  
verified FIXED on debug builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090629 Shiretoko/3.5pre ID:20090629082025

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090629 Minefield/3.6a1pre ID:20090629082126
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Flags: in-testsuite?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: