Closed
Bug 496191
Opened 15 years ago
Closed 15 years ago
Stop using bindFully on collections listing
Categories
(addons.mozilla.org Graveyard :: Collections, defect)
addons.mozilla.org Graveyard
Collections
Tracking
(Not tracked)
RESOLVED
FIXED
5.0.6
People
(Reporter: jbalogh, Assigned: jbalogh)
Details
Attachments
(2 files, 1 obsolete file)
655 bytes,
text/plain
|
Details | |
4.23 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
For reasons similar to bug 495512.
Assignee | ||
Comment 1•15 years ago
|
||
Depends on the patch in bug 495512.
Attachment #381392 -
Flags: review?(clouserw)
Updated•15 years ago
|
Attachment #381392 -
Flags: review?(clouserw) → review-
Comment 2•15 years ago
|
||
Comment on attachment 381392 [details] [diff] [review] pulling less data for collection listing, denormalizing addonCount Binding only users is fine, but I don't like updating the count every time with another query. Normally we'd use a cron for this stuff but let's try out a trigger and see how we like it: CREATE TRIGGER collections_update_addon_count AFTER INSERT ON addons_collections FOR EACH ROW UPDATE collections SET collections.addonCount = collections.addonCount+1 WHERE collections.id=NEW.collection_id; works for me. Also, you'll need to make one for AFTER DELETE. _updateAddonCount() might be a handy function to have around, but let's not call it from addAddonToCollection()
Assignee | ||
Comment 3•15 years ago
|
||
Assignee | ||
Comment 4•15 years ago
|
||
Now with more trigger fingers.
Attachment #381392 -
Attachment is obsolete: true
Attachment #381569 -
Flags: review?(clouserw)
Comment 5•15 years ago
|
||
Comment on attachment 381569 [details] [diff] [review] pulling less data for collection listing, denormalizing addonCount thanks
Attachment #381569 -
Flags: review?(clouserw) → review+
Comment 7•15 years ago
|
||
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Keywords: push-needed
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•