496191 - Stop using bindFully on collections listing

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Jeff Balogh (:jbalogh)]

For reasons similar to bug 495512.

Comment 1

[Jeff Balogh (:jbalogh)]

Attachment: pulling less data for collection listing, denormalizing addonCount

Depends on the patch in bug 495512.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 381392 [details] [diff] [review]
 pulling less data for collection listing, denormalizing addonCount

Binding only users is fine, but I don't like updating the count every time with another query.

Normally we'd use a cron for this stuff but let's try out a trigger and see how we like it:

CREATE TRIGGER collections_update_addon_count AFTER INSERT ON addons_collections FOR EACH ROW
  UPDATE collections SET collections.addonCount = collections.addonCount+1 WHERE collections.id=NEW.collection_id;

works for me.  Also, you'll need to make one for AFTER DELETE.  

_updateAddonCount() might be a handy function to have around, but let's not call it from addAddonToCollection()

Comment 3

[Jeff Balogh (:jbalogh)]

Attachment: migration for addonCount column + triggers

Comment 4

[Jeff Balogh (:jbalogh)]

Attachment: pulling less data for collection listing, denormalizing addonCount

Now with more trigger fingers.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 381569 [details] [diff] [review]
pulling less data for collection listing, denormalizing addonCount

thanks

Comment 6

[Jeff Balogh (:jbalogh)]

r27151.  Will need updates on the preview db.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"